Skip to content

Commit d218b64

Browse files
committed
feat: make plugin manifest required
All plugins must now declare a static manifest property with their metadata and resource requirements. This simplifies the manifest loader and provides better error messages. Signed-off-by: Mario Cadenas <mario.cadenas@databricks.com>
1 parent 95b1d8a commit d218b64

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

packages/shared/src/plugin.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ export interface PluginConfig {
4747
export type PluginPhase = "core" | "normal" | "deferred";
4848

4949
/**
50-
* Plugin constructor with optional manifest and resource requirement declaration.
51-
* Both manifest and getResourceRequirements are optional for backward compatibility.
50+
* Plugin constructor with required manifest declaration.
51+
* All plugins must declare a manifest with their metadata and resource requirements.
5252
*/
5353
export type PluginConstructor<
5454
C = BasePluginConfig,
@@ -60,9 +60,9 @@ export type PluginConstructor<
6060
phase?: PluginPhase;
6161
/**
6262
* Static manifest declaring plugin metadata and resource requirements.
63-
* This is the preferred way to declare resources for all plugins.
63+
* Required for all plugins.
6464
*/
65-
manifest?: PluginManifest;
65+
manifest: PluginManifest;
6666
/**
6767
* Optional runtime resource requirements based on config.
6868
* Use this when resource requirements depend on plugin configuration.

0 commit comments

Comments
 (0)