Revert "Detect mismatch between host defined in config and env variable (#2549) (#2685)

## Changes

This reverts commit 314766a.

## Why

In the Web Terminal, the `DATABRICKS_HOST` environment variable is
always set to the shard host, which may cause unexpected host mismatch
validation errors.

Addresses #2672.

Author: ilyakuz-db

NEXT_CHANGELOG.md

@@ -16,5 +16,6 @@
 * Removed pipeline 'deployment' field from jsonschema ([#2653](https://github.com/databricks/cli/pull/2653))
 * Updated JSON schema for deprecated pipeline fields ([#2646](https://github.com/databricks/cli/pull/2646))
 * The --config-dir and --source-dir flags for "bundle generate app" are now relative to CWD, not bundle root ([#2683](https://github.com/databricks/cli/pull/2683))
+* Reverts [#2549](https://github.com/databricks/cli/pull/2549) to resolve issues with Web Terminal host mismatch ([#2685](https://github.com/databricks/cli/pull/2685))
 
 ### API Changes

acceptance/auth/bundle_and_env/.databrickscfg

@@ -16,6 +16,7 @@
 10:07:59 Debug: Apply pid=12345 mutator=<func>
 10:07:59 Info: Phase: initialize pid=12345
 10:07:59 Debug: Apply pid=12345 mutator=validate:AllResourcesHaveValues
+10:07:59 Debug: Apply pid=12345 mutator=validate:interpolation_in_auth_config
 10:07:59 Debug: Apply pid=12345 mutator=RewriteSyncPaths
 10:07:59 Debug: Apply pid=12345 mutator=SyncDefaultPath
 10:07:59 Debug: Apply pid=12345 mutator=SyncInferRoot

acceptance/auth/bundle_and_env/databricks.yml

@@ -7,14 +7,19 @@ Warning: Variable interpolation is not supported for fields that configure authe
 Interpolation is not supported for the field workspace.host. Please set
 the DATABRICKS_HOST environment variable if you wish to configure this field at runtime.
 
-Error: cannot resolve bundle auth configuration: config host mismatch: DATABRICKS_HOST is defined as [DATABRICKS_URL], but CLI configured to use ${var.host}
+Error: failed during request visitor: parse "https://${var.host}": invalid character "{" in host name
 
 {
   "bundle": {
     "environment": "default",
     "name": "host",
     "target": "default"
   },
+  "sync": {
+    "paths": [
+      "."
+    ]
+  },
   "targets": null,
   "variables": {
     "host": {
@@ -36,7 +41,7 @@ Warning: Variable interpolation is not supported for fields that configure authe
 Interpolation is not supported for the field workspace.host. Please set
 the DATABRICKS_HOST environment variable if you wish to configure this field at runtime.
 
-Error: cannot resolve bundle auth configuration: config host mismatch: DATABRICKS_HOST is defined as [DATABRICKS_URL], but CLI configured to use ${var.host}
+Error: failed during request visitor: parse "https://${var.host}": invalid character "{" in host name
 
 Name: host
 Target: default

acceptance/auth/bundle_and_env/output.txt

@@ -0,0 +1,83 @@
+package validate
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/databricks/cli/bundle"
+	"github.com/databricks/cli/libs/auth"
+	"github.com/databricks/cli/libs/diag"
+	"github.com/databricks/cli/libs/dyn"
+	"github.com/databricks/cli/libs/dyn/dynvar"
+)
+
+type noInterpolationInAuthConfig struct{}
+
+func NoInterpolationInAuthConfig() bundle.Mutator {
+	return &noInterpolationInAuthConfig{}
+}
+
+func (f *noInterpolationInAuthConfig) Name() string {
+	return "validate:interpolation_in_auth_config"
+}
+
+func (f *noInterpolationInAuthConfig) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
+	authFields := []string{
+		// Generic attributes.
+		"host",
+		"profile",
+		"auth_type",
+		"metadata_service_url",
+
+		// OAuth specific attributes.
+		"client_id",
+
+		// Google specific attributes.
+		"google_service_account",
+
+		// Azure specific attributes.
+		"azure_resource_id",
+		"azure_use_msi",
+		"azure_client_id",
+		"azure_tenant_id",
+		"azure_environment",
+		"azure_login_app_id",
+	}
+
+	diags := diag.Diagnostics{}
+
+	for _, fieldName := range authFields {
+		p := dyn.NewPath(dyn.Key("workspace"), dyn.Key(fieldName))
+		v, err := dyn.GetByPath(b.Config.Value(), p)
+		if dyn.IsNoSuchKeyError(err) {
+			continue
+		}
+		if err != nil {
+			return diag.FromErr(err)
+		}
+
+		vv, ok := v.AsString()
+		if !ok {
+			continue
+		}
+
+		// Check if the field contains interpolation.
+		if dynvar.ContainsVariableReference(vv) {
+			envVar, ok := auth.GetEnvFor(fieldName)
+			if !ok {
+				continue
+			}
+
+			diags = append(diags, diag.Diagnostic{
+				Severity: diag.Warning,
+				Summary:  "Variable interpolation is not supported for fields that configure authentication",
+				Detail: fmt.Sprintf(`Interpolation is not supported for the field %s. Please set
+the %s environment variable if you wish to configure this field at runtime.`, p.String(), envVar),
+				Locations: v.Locations(),
+				Paths:     []dyn.Path{p},
+			})
+		}
+	}
+
+	return diags
+}

acceptance/auth/bundle_and_env/script

@@ -1,12 +1,10 @@
 package config
 
 import (
-	"fmt"
 	"os"
 	"path/filepath"
 
 	"github.com/databricks/cli/libs/databrickscfg"
-	"github.com/databricks/cli/libs/workspace"
 	"github.com/databricks/databricks-sdk-go"
 	"github.com/databricks/databricks-sdk-go/config"
 	"github.com/databricks/databricks-sdk-go/marshal"
@@ -150,34 +148,9 @@ func (w *Workspace) Client() (*databricks.WorkspaceClient, error) {
 		}
 	}
 
-	if w.Host != "" && w.Profile == "" {
-		err := validateConfigAndEnvHost(cfg)
-		if err != nil {
-			return nil, err
-		}
-	}
-
 	return databricks.NewWorkspaceClient((*databricks.Config)(cfg))
 }
 
-func validateConfigAndEnvHost(cfg *config.Config) error {
-	var hostEnvName, hostEnvVal string
-	for _, attr := range config.ConfigAttributes {
-		if attr.Name == "host" {
-			hostEnvVal, hostEnvName = attr.ReadEnv()
-			break
-		}
-	}
-	if hostEnvName == "" || hostEnvVal == "" {
-		return nil
-	}
-
-	if !workspace.MatchHost(hostEnvVal, cfg.Host) {
-		return fmt.Errorf("config host mismatch: %s is defined as %s, but CLI configured to use %s", hostEnvName, hostEnvVal, cfg.Host)
-	}
-	return nil
-}
-
 func init() {
 	arg0 := os.Args[0]