Skip to content

Commit 04b9cdb

Browse files
fix: swapped output of symlink (#3361)
## Changes Bug fix: before, on installing pipelines for the first time, users are told that pipelines is reinstalled, while when overwriting their pipelines symlink, users are told pipelines is installed, without mention of the deletion. Swapped output of print statements to match the actual expected output. --------- Co-authored-by: Jeffery Cheng <[email protected]>
1 parent 6fb92c1 commit 04b9cdb

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

acceptance/pipelines/install-pipelines-cli/output.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
=== install pipelines cli
33
>>> [CLI] install-pipelines-cli -d ./subdir
4-
found existing pipelines installation at subdir/pipelines. Pipelines is successfully reinstalled in directory "./subdir"
4+
pipelines successfully installed in directory "./subdir"
55

66
>>> ./subdir/pipelines
77
Pipelines CLI
@@ -45,7 +45,7 @@ Exit code: 1
4545

4646
=== databricks executable called with alias
4747
>>> ./subdir/notdatabricks install-pipelines-cli -d ./subdir
48-
found existing pipelines installation at subdir/pipelines. Pipelines is successfully reinstalled in directory "./subdir"
48+
pipelines successfully installed in directory "./subdir"
4949

5050
>>> ./subdir/pipelines
5151
Pipelines CLI
@@ -79,10 +79,10 @@ Use "pipelines [command] --help" for more information about a command.
7979

8080
=== overwrites broken symlink pointing to databricks
8181
>>> ./subdir/olddatabricks install-pipelines-cli -d ./subdir
82-
found existing pipelines installation at subdir/pipelines. Pipelines is successfully reinstalled in directory "./subdir"
82+
pipelines successfully installed in directory "./subdir"
8383

8484
>>> [CLI] install-pipelines-cli -d ./subdir
85-
pipelines successfully installed in directory "./subdir"
85+
found existing pipelines installation at subdir/pipelines. Pipelines CLI is successfully reinstalled in directory "./subdir"
8686

8787
>>> ./subdir/pipelines
8888
Pipelines CLI

cmd/pipelines/install_pipelines_cli.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func installPipelinesSymlink(ctx context.Context, directory string) error {
3838
if err != nil {
3939
return err
4040
}
41-
cmdio.LogString(ctx, fmt.Sprintf("found existing pipelines installation at %s. Pipelines is successfully reinstalled in directory %q", pipelinesPath, dir))
41+
cmdio.LogString(ctx, fmt.Sprintf("pipelines successfully installed in directory %q", dir))
4242
return nil
4343
}
4444

@@ -54,7 +54,7 @@ func installPipelinesSymlink(ctx context.Context, directory string) error {
5454
if err != nil {
5555
return err
5656
}
57-
cmdio.LogString(ctx, fmt.Sprintf("pipelines successfully installed in directory %q", dir))
57+
cmdio.LogString(ctx, fmt.Sprintf("found existing pipelines installation at %s. Pipelines CLI is successfully reinstalled in directory %q", pipelinesPath, dir))
5858
return nil
5959
}
6060
return err

0 commit comments

Comments
 (0)