lint & fix

Author: denik

bundle/direct/bundle_apply.go

@@ -51,7 +51,7 @@ func (b *DeploymentBundle) Apply(ctx context.Context, client *databricks.Workspa
 		action := entry.Action
 		errorPrefix := fmt.Sprintf("cannot %s %s", action, resourceKey)
 		if migrateMode {
-			errorPrefix = fmt.Sprintf("cannot migrate %s", resourceKey)
+			errorPrefix = "cannot migrate " + resourceKey
 		}
 
 		at := deployplan.ActionTypeFromString(action)

bundle/statemgmt/state_pull.go

@@ -116,28 +116,26 @@ func PullResourcesState(ctx context.Context, b *bundle.Bundle, alwaysPull Always
 	}
 
 	var winner *StateDesc
-	var directDeployment bool
 
 	if len(states) == 0 {
 		// no local or remote state; set directDeployment based on env vars
-		isDirect, err := getDirectDeploymentEnv(ctx)
+		directDeployment, err := getDirectDeploymentEnv(ctx)
 		if err != nil {
 			logdiag.LogError(ctx, err)
 			return ctx, nil
 		}
 		winner = &StateDesc{
-			IsDirect: isDirect,
+			IsDirect: directDeployment,
 			IsLocal:  true,
 			// Lineage and Serial are empty
 		}
 	} else {
 		winner = states[len(states)-1]
-		directDeployment = winner.IsDirect
 	}
 
 	engine := "direct"
 
-	if !directDeployment {
+	if !winner.IsDirect {
 		engine = "terraform"
 	}
 

cmd/bundle/deployment/migrate.go

@@ -73,7 +73,7 @@ To start using direct engine, deploy with DATABRICKS_BUNDLE_ENGINE=direct env va
 		_, localPath := b.StateFilenameDirect(ctx)
 		tempStatePath := localPath + ".temp-migration"
 		if _, err = os.Stat(tempStatePath); err == nil {
-			return fmt.Errorf("temporary state file %s already exists, another migration is in progress or was interrupated. In the latter case, delete the file.", tempStatePath)
+			return fmt.Errorf("temporary state file %s already exists, another migration is in progress or was interrupated. In the latter case, delete the file", tempStatePath)
 		}
 		if _, err = os.Stat(localPath); err == nil {
 			return fmt.Errorf("state file %s already exists", localPath)