Fix checkForPreventDestroy to check all resources if some does not have prevent_destroy set (#3615)

## Changes
Previously, `checkForPreventDestroy` aborted earlier if it encountered a
resource with no prevent_destroy set, and wouldn't check the rest of the
resources.
Now this is fixed to check all resources.

## Why
Fixes a bug in `checkForPreventDestroy`

## Tests
Added a regression unit test for `checkForPreventDestroy`

<!-- If your PR needs to be included in the release notes for next
release,
add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->

Author: andrewnester

NEXT_CHANGELOG.md

@@ -9,5 +9,6 @@
 ### Dependency updates
 
 ### Bundles
+* Fix checkForPreventDestroy to check all resources if some does not have prevent_destroy set ([#3615](https://github.com/databricks/cli/pull/3615))
 
 ### API Changes

bundle/phases/plan.go

@@ -62,10 +62,10 @@ func checkForPreventDestroy(b *bundle.Bundle, actions []deployplan.Action) error
 		}
 
 		path := dyn.NewPath(dyn.Key("resources"), dyn.Key(action.Group), dyn.Key(action.Key), dyn.Key("lifecycle"), dyn.Key("prevent_destroy"))
-		// If there is no prevent_destroy, skip
+		// If there is no prevent_destroy, skip and check other resources
 		preventDestroyV, err := dyn.GetByPath(root, path)
 		if err != nil {
-			return nil
+			continue
 		}
 
 		preventDestroy, ok := preventDestroyV.AsBool()

bundle/phases/plan_test.go

@@ -7,8 +7,11 @@ import (
 
 	"github.com/databricks/cli/bundle"
 	"github.com/databricks/cli/bundle/config"
+	"github.com/databricks/cli/bundle/config/resources"
 	"github.com/databricks/cli/bundle/deployplan"
 	"github.com/databricks/cli/libs/dyn"
+	"github.com/databricks/databricks-sdk-go/service/apps"
+	"github.com/databricks/databricks-sdk-go/service/jobs"
 	"github.com/stretchr/testify/require"
 )
 
@@ -62,3 +65,58 @@ func TestCheckPreventDestroyForAllResources(t *testing.T) {
 		})
 	}
 }
+
+func TestCheckForPreventDestroyWhenFirstHasNoPreventDestroy(t *testing.T) {
+	b := &bundle.Bundle{
+		Config: config.Root{
+			Bundle: config.Bundle{
+				Name: "test",
+			},
+			Resources: config.Resources{
+				Jobs: map[string]*resources.Job{
+					"test_job": {
+						JobSettings: jobs.JobSettings{
+							Tasks: []jobs.Task{},
+						},
+					},
+				},
+				Apps: map[string]*resources.App{
+					"test_app": {
+						App: apps.App{
+							Name: "Test App",
+						},
+						BaseResource: resources.BaseResource{
+							Lifecycle: resources.Lifecycle{
+								PreventDestroy: true,
+							},
+						},
+					},
+				},
+			},
+		},
+	}
+
+	actions := []deployplan.Action{
+		{
+			ResourceNode: deployplan.ResourceNode{
+				Group: "jobs",
+				Key:   "test_job",
+			},
+			ActionType: deployplan.ActionTypeRecreate,
+		},
+		{
+			ResourceNode: deployplan.ResourceNode{
+				Group: "apps",
+				Key:   "test_app",
+			},
+			ActionType: deployplan.ActionTypeRecreate,
+		},
+	}
+
+	ctx := context.Background()
+	bundle.ApplyFuncContext(ctx, b, func(ctx context.Context, b *bundle.Bundle) {
+		err := checkForPreventDestroy(b, actions)
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "resource test_app has lifecycle.prevent_destroy set")
+	})
+}