Skip to content

Commit 0d93a6f

Browse files
authored
Use shorter names for test jobs (#4065)
## Changes Make primary test jobs name explicit. The default expansion includes all matrix fields. Previous names: * tests (databricks-protected-runner-group-large, linux-ubuntu-latest-large, terraform) * tests (databricks-protected-runner-group-large, linux-ubuntu-latest-large, direct) New names: * make test (linux, direct) * make test (linux, terraform) ## Why The test names are so long that you can't see how long they ran for.
1 parent edcc112 commit 0d93a6f

File tree

1 file changed

+29
-8
lines changed

1 file changed

+29
-8
lines changed

.github/workflows/push.yml

Lines changed: 29 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,31 +70,52 @@ jobs:
7070
# Always run all tests
7171
echo "targets=[\"test\"]" >> $GITHUB_OUTPUT
7272
73-
tests:
73+
test:
7474
needs:
7575
- cleanups
7676
- testmask
7777

7878
# Only run if the target is in the list of targets from testmask
7979
if: ${{ contains(fromJSON(needs.testmask.outputs.targets), 'test') }}
80-
runs-on: ${{ matrix.os }}
80+
name: "make test (${{matrix.os.name}}, ${{matrix.deployment}})"
81+
runs-on: ${{ matrix.os.runner }}
8182

8283
strategy:
8384
fail-fast: false
8485
matrix:
86+
# Use separate fields for the OS name and runner configuration.
87+
# When combined in a single object, "runs-on" errors with "Unexpected value 'name'".
8588
os:
86-
- group: databricks-protected-runner-group-large
87-
labels: linux-ubuntu-latest-large
89+
- name: linux
90+
runner:
91+
group: databricks-protected-runner-group-large
92+
labels: linux-ubuntu-latest-large
93+
94+
- name: windows
95+
runner:
96+
group: databricks-protected-runner-group-large
97+
labels: windows-server-latest-large
8898

89-
# On merge_group events, only run the tests on Linux, to reduce time to merge.
90-
- ${{ github.event_name != 'merge_group' && fromJSON('{"group":"databricks-protected-runner-group-large","labels":"windows-server-latest-large"}') || null }}
91-
- ${{ github.event_name != 'merge_group' && 'macos-latest' || null }}
99+
- name: macos
100+
runner:
101+
labels: macos-latest
92102

93103
deployment:
94104
- "terraform"
95105
- "direct"
106+
107+
# Include "event_name" in the matrix so we can include/exclude based on it.
108+
event:
109+
- ${{ github.event_name }}
110+
111+
# Run on Linux only in merge queue to reduce time to merge.
96112
exclude:
97-
- os: null
113+
- event: merge_group
114+
os:
115+
name: windows
116+
- event: merge_group
117+
os:
118+
name: macos
98119

99120
steps:
100121
- name: Checkout repository and submodules

0 commit comments

Comments
 (0)