Rename DATABRICKS_CLI_DEPLOYMENT to DATABRICKS_CLI_BUNDLE_ENGINE (#3616)

## Why
Deployment is an overloaded term. Engine helps better disambiguate
between the module used to perform the deployment.

## Tests
Existing tests.

Author: shreyas-goenka

.github/workflows/push.yml

@@ -82,14 +82,14 @@ jobs:
         # populates the cache and cache may include test results.
         if: ${{ github.event_name == 'pull_request' || github.event_name == 'schedule' }}
         env:
-          ENVFILTER: DATABRICKS_CLI_DEPLOYMENT=${{ matrix.deployment }}
+          ENVFILTER: DATABRICKS_BUNDLE_ENGINE=${{ matrix.deployment }}
         run: make test
 
       - name: Run tests with coverage
         # Still run 'make cover' on push to main and merge checks to make sure it does not get broken.
         if: ${{ github.event_name != 'pull_request' && github.event_name != 'schedule' }}
         env:
-          ENVFILTER: DATABRICKS_CLI_DEPLOYMENT=${{ matrix.deployment }}
+          ENVFILTER: DATABRICKS_BUNDLE_ENGINE=${{ matrix.deployment }}
         run: make cover
 
       - name: Analyze slow tests

AGENTS.md

@@ -367,7 +367,7 @@ func getEnvFilters(t *testing.T) []string {
 		// Clear it just to be sure, since it's going to be part of os.Environ() and we're going to add different value based on settings.
 		os.Unsetenv(key)
 
-		if key == "DATABRICKS_CLI_DEPLOYMENT" && items[1] == "direct" {
+		if key == "DATABRICKS_BUNDLE_ENGINE" && items[1] == "direct" {
 			// CLI only recognizes "direct-exp" at the moment, but in the future will recognize "direct" as well.
 			// On CI we set "direct". To avoid renaming jobs in CI on the future, we correct direct -> direct-exp here
 			items[1] = "direct-exp"
@@ -1393,7 +1393,7 @@ func loadUserReplacements(t *testing.T, repls *testdiff.ReplacementsContext, tmp
 
 type pathFilter struct {
 	// contains substrings from the variants other than current.
-	// E.g. if EnvVaryOutput is DATABRICKS_CLI_DEPLOYMENT and current test running DATABRICKS_CLI_DEPLOYMENT="terraform" then
+	// E.g. if EnvVaryOutput is DATABRICKS_BUNDLE_ENGINE and current test running DATABRICKS_BUNDLE_ENGINE="terraform" then
 	// notSelected contains ".direct-exp." meaning if filename contains that (e.g. out.deploy.direct-exp.txt) then we ignore it here.
 	notSelected []string
 }

acceptance/acceptance_test.go

@@ -41,7 +41,7 @@ def print_resource_direct(group, name):
     print(result.get("__id__"))
 
 
-if os.environ.get("DATABRICKS_CLI_DEPLOYMENT", "").startswith("direct"):
+if os.environ.get("DATABRICKS_BUNDLE_ENGINE", "").startswith("direct"):
     print_resource_direct(*sys.argv[1:])
 else:
     print_resource_terraform(*sys.argv[1:])

acceptance/auth/bundle_and_profile/out.test.toml

@@ -48,7 +48,7 @@ def print_resource_direct(group, name, *attrs):
     print(group, name, " ".join(values))
 
 
-if os.environ.get("DATABRICKS_CLI_DEPLOYMENT", "").startswith("direct"):
+if os.environ.get("DATABRICKS_BUNDLE_ENGINE", "").startswith("direct"):
     print_resource_direct(*sys.argv[1:])
 else:
     print_resource_terraform(*sys.argv[1:])