Skip to content

Commit 13fa43e

Browse files
authored
Remove superfluous helper (#2028)
## Changes There was only one helper for AWS and not the other clouds. Found this when looking through double calls to `acc.WorkspaceTest()` (see `TestPythonWheelTaskDeployAndRunOnInteractiveCluster`). ## Tests n/a
1 parent 23ddee8 commit 13fa43e

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

integration/bundle/clusters_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ import (
1212
)
1313

1414
func TestDeployBundleWithCluster(t *testing.T) {
15-
ctx, wt := acc.WorkspaceTest(t)
16-
17-
if testutil.IsAWSCloud(wt) {
15+
if testutil.GetCloud(t) == testutil.AWS {
1816
t.Skip("Skipping test for AWS cloud because it is not permitted to create clusters")
1917
}
2018

19+
ctx, wt := acc.WorkspaceTest(t)
20+
2121
nodeTypeId := testutil.GetCloud(t).NodeTypeID()
2222
uniqueId := uuid.New().String()
2323
root := initTestTemplate(t, ctx, "clusters", map[string]any{

integration/bundle/python_wheel_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,7 @@ func TestPythonWheelTaskDeployAndRunWithWrapper(t *testing.T) {
5656
}
5757

5858
func TestPythonWheelTaskDeployAndRunOnInteractiveCluster(t *testing.T) {
59-
_, wt := acc.WorkspaceTest(t)
60-
61-
if testutil.IsAWSCloud(wt) {
59+
if testutil.GetCloud(t) == testutil.AWS {
6260
t.Skip("Skipping test for AWS cloud because it is not permitted to create clusters")
6361
}
6462

internal/testutil/cloud.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,3 @@ func GetCloud(t TestingT) Cloud {
5858
}
5959
return -1
6060
}
61-
62-
func IsAWSCloud(t TestingT) bool {
63-
return GetCloud(t) == AWS
64-
}

0 commit comments

Comments
 (0)