direct: internal cleanups: rm unnecessary check; update comments (#3461)

Author: denik

bundle/terranova/plan.go

@@ -151,6 +151,8 @@ func CalculatePlanForDeploy(ctx context.Context, b *bundle.Bundle) error {
 		}
 
 		if b.Graph.HasOutgoingEdges(node) && actionType.KeepsID() {
+			// Now that we know that ID of this node is not going to change, update it
+			// everywhere to actual value to calculate more accurate and more conservative plan.
 			err = resolveIDReference(ctx, b, pl.group, pl.resourceName)
 			if err != nil {
 				logdiag.LogError(ctx, fmt.Errorf("failed to replace ref to resources.%s.%s.id: %w", pl.group, pl.resourceName, err))

bundle/terranova/tnresources/job.go

@@ -17,7 +17,6 @@ type ResourceJob struct {
 func NewResourceJob(client *databricks.WorkspaceClient, job *resources.Job) (*ResourceJob, error) {
 	return &ResourceJob{
 		client: client,
-		// TODO Use Processor with explicit field mapping
 		config: job.JobSettings,
 	}, nil
 }
@@ -65,6 +64,8 @@ func (r *ResourceJob) WaitAfterUpdate(ctx context.Context) error {
 }
 
 func makeCreateJob(config jobs.JobSettings) (jobs.CreateJob, error) {
+	// Note, exhaustruct linter validates that all off CreateJob fields are initialized.
+	// We don't have linter that validates that all of config fields are used.
 	result := jobs.CreateJob{
 		AccessControlList:    nil, // Not supported by DABs
 		BudgetPolicyId:       config.BudgetPolicyId,
@@ -92,12 +93,9 @@ func makeCreateJob(config jobs.JobSettings) (jobs.CreateJob, error) {
 		Trigger:              config.Trigger,
 		UsagePolicyId:        config.UsagePolicyId,
 		WebhookNotifications: config.WebhookNotifications,
-
-		ForceSendFields: filterFields[jobs.CreateJob](config.ForceSendFields),
+		ForceSendFields:      filterFields[jobs.CreateJob](config.ForceSendFields),
 	}
 
-	// TODO: Validate copy - all fields must be initialized or explicitly allowed to be empty
-	// Unset AccessControlList
 	return result, nil
 }
 
@@ -106,7 +104,9 @@ func makeResetJob(config jobs.JobSettings, id string) (jobs.ResetJob, error) {
 	if err != nil {
 		return jobs.ResetJob{}, err
 	}
-	result := jobs.ResetJob{JobId: idInt, NewSettings: config}
-	// TODO: Validate copy - all fields must be initialized or explicitly allowed to be empty
+	result := jobs.ResetJob{
+		JobId:       idInt,
+		NewSettings: config,
+	}
 	return result, err
 }

bundle/terranova/tnresources/volume.go

@@ -98,11 +98,7 @@ func (r *ResourceVolume) DoUpdateWithID(ctx context.Context, id string) (string,
 }
 
 func DeleteVolume(ctx context.Context, client *databricks.WorkspaceClient, id string) error {
-	err := client.Volumes.DeleteByName(ctx, id)
-	if err != nil {
-		return err
-	}
-	return nil
+	return client.Volumes.DeleteByName(ctx, id)
 }
 
 func (r *ResourceVolume) WaitAfterCreate(ctx context.Context) error {