direct: volumes: fix updating the name (#3349)

## Changes
- Add missing setting for volumes: UpdateUpdatesID. Without it, updating
the name fails with internal error.
- Update testserver to properly handle name updates.

## Why
Follow up to #3342

## Tests
New acceptance test.

Author: denik

acceptance/bundle/resources/volumes/change-comment/test.toml

@@ -1,4 +1,3 @@
 Ignore = [
-    "tmp.summary.txt",
     ".databricks",
 ]

acceptance/bundle/resources/volumes/change-name/databricks.yml

@@ -0,0 +1,7 @@
+resources:
+  volumes:
+    volume1:
+      catalog_name: main
+      schema_name: myschema
+      name: myvolume
+      comment: COMMENT1

acceptance/bundle/resources/volumes/change-name/out.test.toml

@@ -0,0 +1,5 @@
+Local = true
+Cloud = false
+
+[EnvMatrix]
+  DATABRICKS_CLI_DEPLOYMENT = ["terraform", "direct-exp"]

acceptance/bundle/resources/volumes/change-name/output.txt

@@ -0,0 +1,71 @@
+
+>>> [CLI] bundle deploy
+Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
+Deploying resources...
+Updating deployment state...
+Deployment complete!
+
+>>> print_requests
+{
+  "method": "POST",
+  "path": "/api/2.1/unity-catalog/volumes",
+  "body": {
+    "catalog_name": "main",
+    "comment": "COMMENT1",
+    "name": "myvolume",
+    "schema_name": "myschema",
+    "volume_type": "MANAGED"
+  }
+}
+
+=== Summary should now show id and url
+{
+  "volumes": {
+    "volume1": {
+      "catalog_name": "main",
+      "comment": "COMMENT1",
+      "id": "main.myschema.myvolume",
+      "name": "myvolume",
+      "schema_name": "myschema",
+      "url": "[DATABRICKS_URL]/explore/data/volumes/main/myschema/myvolume?o=[NUMID]",
+      "volume_type": "MANAGED"
+    }
+  }
+}
+
+=== Update name
+>>> update_file.py databricks.yml myvolume mynewvolume
+
+>>> [CLI] bundle plan
+update volumes.volume1
+
+>>> [CLI] bundle deploy
+Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
+Deploying resources...
+Updating deployment state...
+Deployment complete!
+
+>>> print_requests
+{
+  "method": "PATCH",
+  "path": "/api/2.1/unity-catalog/volumes/main.myschema.myvolume",
+  "body": {
+    "comment": "COMMENT1",
+    "new_name": "mynewvolume"
+  }
+}
+
+>>> [CLI] volumes read main.myschema.mynewvolume
+{
+  "catalog_name":"main",
+  "comment":"COMMENT1",
+  "full_name":"main.myschema.mynewvolume",
+  "name":"mynewvolume",
+  "schema_name":"myschema",
+  "volume_type":"MANAGED"
+}
+
+>>> musterr [CLI] volumes read main.myschema.myvolume
+Error: Resource catalog.VolumeInfo not found: main.myschema.myvolume
+
+Exit code (musterr): 1

acceptance/bundle/resources/volumes/change-name/script

@@ -0,0 +1,22 @@
+trace $CLI bundle deploy
+
+print_requests() {
+    jq 'select(.method != "GET" and (.path | contains("/unity")))' < out.requests.txt
+    rm out.requests.txt
+}
+
+trace print_requests
+
+title "Summary should now show id and url\n"
+$CLI bundle summary -o json | jq .resources
+
+title "Update name"
+trace update_file.py databricks.yml myvolume mynewvolume
+
+trace $CLI bundle plan
+trace $CLI bundle deploy
+trace print_requests
+
+trace $CLI volumes read main.myschema.mynewvolume
+trace musterr $CLI volumes read main.myschema.myvolume
+rm out.requests.txt

acceptance/bundle/resources/volumes/change-name/test.toml

@@ -0,0 +1,3 @@
+Ignore = [
+    ".databricks",
+]

acceptance/bundle/resources/volumes/change-schema-name/test.toml

@@ -1,4 +1,3 @@
 Ignore = [
-    "tmp.summary.txt",
     ".databricks",
 ]

bundle/terranova/resource.go

@@ -94,9 +94,10 @@ var SupportedResources = map[string]ResourceSettings{
 		),
 	},
 	"volumes": {
-		New:        reflect.ValueOf(tnresources.NewResourceVolume),
-		ConfigType: TypeOfConfig(&tnresources.ResourceVolume{}),
-		DeleteFN:   tnresources.DeleteVolume,
+		New:             reflect.ValueOf(tnresources.NewResourceVolume),
+		ConfigType:      TypeOfConfig(&tnresources.ResourceVolume{}),
+		DeleteFN:        tnresources.DeleteVolume,
+		UpdateUpdatesID: true,
 		// TF: https://github.com/databricks/terraform-provider-databricks/blob/f5fce0f/catalog/resource_volume.go#L19
 		RecreateFields: mkMap(
 			".catalog_name",

libs/testserver/volumes.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"net/http"
 
-	"dario.cat/mergo"
 	"github.com/databricks/databricks-sdk-go/service/catalog"
 )
 
@@ -29,34 +28,40 @@ func (s *FakeWorkspace) VolumesCreate(req Request) Response {
 	}
 }
 
-func (s *FakeWorkspace) VolumesUpdate(req Request, name string) Response {
+func (s *FakeWorkspace) VolumesUpdate(req Request, fullname string) Response {
 	defer s.LockUnlock()()
 
-	existing, ok := s.Volumes[name]
+	existing, ok := s.Volumes[fullname]
 	if !ok {
 		return Response{
 			StatusCode: 404,
 		}
 	}
 
-	var volume catalog.VolumeInfo
+	var request catalog.UpdateVolumeRequestContent
 
-	if err := json.Unmarshal(req.Body, &volume); err != nil {
+	if err := json.Unmarshal(req.Body, &request); err != nil {
 		return Response{
 			Body:       fmt.Sprintf("internal error: %s", err),
 			StatusCode: http.StatusInternalServerError,
 		}
 	}
 
-	err := mergo.Merge(&existing, volume, mergo.WithOverride)
-	if err != nil {
-		return Response{
-			Body:       fmt.Sprintf("mergo error: %s", err),
-			StatusCode: http.StatusInternalServerError,
-		}
+	if request.Comment != "" {
+		existing.Comment = request.Comment
+	}
+
+	if request.Owner != "" {
+		existing.Owner = request.Owner
+	}
+
+	if request.NewName != "" {
+		delete(s.Volumes, fullname)
+		existing.Name = request.NewName
+		existing.FullName = existing.CatalogName + "." + existing.SchemaName + "." + request.NewName
 	}
 
-	s.Volumes[name] = existing
+	s.Volumes[existing.FullName] = existing
 	return Response{
 		Body: existing,
 	}