Fix for pip flags with equal sign being incorrectly treated as local file names (#3766)

## Changes
Fix for pip flags with equal sign being incorrectly treated as local
file names

## Why
Pip flags containing an equal sign and used in the environment
dependencies section were incorrectly treated as local file names,
leading to the bundle deploy error.

## Tests
Added test case for this

<!-- If your PR needs to be included in the release notes for next
release,
add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->

Author: andrewnester

NEXT_CHANGELOG.md

@@ -12,5 +12,6 @@
 
 ### Bundles
 * Updated the internal lakeflow-pipelines template to use an "src" layout ([#3671](https://github.com/databricks/cli/pull/3671)).
+* Fix for pip flags with equal sign being incorrectly treated as local file names ([#3766](https://github.com/databricks/cli/pull/3766))
 
 ### API Changes

acceptance/bundle/environments/dependencies/databricks.yml

@@ -32,6 +32,7 @@ resources:
               - "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0"
               - "beautifulsoup4[security, tests] ~= 4.12.3"
               - "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip"
+              - "--find-links=/Workspace/Users/test"
 
   pipelines:
     test_pipeline:
@@ -49,3 +50,4 @@ resources:
           - "test_package>=2.0.1"
           - "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0"
           - "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip"
+          - "--find-links=/Workspace/Users/test"

acceptance/bundle/environments/dependencies/output.txt

@@ -33,7 +33,8 @@ Deployment complete!
         "/Workspace/Users/[email protected]/test-package.whl",
         "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
         "beautifulsoup4[security, tests] ~= 4.12.3",
-        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip"
+        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
+        "--find-links=/Workspace/Users/test"
       ]
     }
   },
@@ -71,7 +72,8 @@ Deployment complete!
         "test_package==2.0.1",
         "test_package>=2.0.1",
         "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
-        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip"
+        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
+        "--find-links=/Workspace/Users/test"
       ]
     },
     "name": "Test Pipeline"
@@ -96,7 +98,8 @@ Deployment complete!
         "/Workspace/Users/[email protected]/test-package.whl",
         "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
         "beautifulsoup4[security, tests] ~= 4.12.3",
-        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip"
+        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
+        "--find-links=/Workspace/Users/test"
       ]
     }
   },
@@ -124,6 +127,7 @@ Deployment complete!
     "test_package==2.0.1",
     "test_package>=2.0.1",
     "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
-    "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip"
+    "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
+    "--find-links=/Workspace/Users/test"
   ]
 }

bundle/libraries/local_path.go

@@ -95,7 +95,7 @@ func containsPipFlag(input string) bool {
 	// Trailing space means the the flag takes an argument or there's multiple arguments in input
 	// Alternatively it could be a flag with no argument and no space after it
 	// For example: -r myfile.txt or --index-url http://myindexurl.com or -i
-	re := regexp.MustCompile(`(^|\s+)--?[a-zA-Z0-9-]+(\s+|$)`)
+	re := regexp.MustCompile(`(^|\s+)--?[a-zA-Z0-9-]+(([\s|=]+)|$)`)
 	return re.MatchString(input)
 }
 

bundle/libraries/local_path_test.go

@@ -63,9 +63,15 @@ func TestIsLibraryLocal(t *testing.T) {
 		{path: "-e some/local/path", expected: false},
 		{path: "-i http://myindexurl.com", expected: false},
 		{path: "--index-url http://myindexurl.com", expected: false},
+		{path: "--index-url      http://myindexurl.com", expected: false},
 		{path: "-i", expected: false},
 		{path: "--index-url", expected: false},
 		{path: "-i -e", expected: false},
+		{path: "--find-links=/Workspace/Users/test", expected: false},
+		{path: "--find-links = /Workspace/Users/test.whl", expected: false},
+		{path: "--find-links =/Workspace/Users/test.whl", expected: false},
+		{path: "--find-links    =    /Workspace/Users/test.whl", expected: false},
+		{path: "--find-links /Workspace/Users/test", expected: false},
 
 		// Check the possible version specifiers as in PEP 440
 		// https://peps.python.org/pep-0440/#public-version-identifiers