Skip to content

Commit 29e9930

Browse files
authored
Fix "make cover" (#4059)
## Changes The `TEST_PACKAGES` variable no longer includes acceptance tests (#4017). This made the step that merges acceptance test coverage fail. ## Tests Locally: ``` make cover TEST_PACKAGES=./libs/env ACCEPTANCE_TEST_FILTER=TestAccept/selftest ```
1 parent e57befa commit 29e9930

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ slowest:
9898

9999
cover:
100100
rm -fr ./acceptance/build/cover/
101-
VERBOSE_TEST=1 CLI_GOCOVERDIR=build/cover ${GOTESTSUM_CMD} --packages ${TEST_PACKAGES} -- -coverprofile=coverage.txt -timeout=${LOCAL_TIMEOUT}
101+
VERBOSE_TEST=1 ${GOTESTSUM_CMD} --packages "${TEST_PACKAGES}" -- -coverprofile=coverage.txt -timeout=${LOCAL_TIMEOUT}
102+
VERBOSE_TEST=1 CLI_GOCOVERDIR=build/cover ${GOTESTSUM_CMD} --packages ./acceptance/... -- -timeout=${LOCAL_TIMEOUT} -run ${ACCEPTANCE_TEST_FILTER}
102103
rm -fr ./acceptance/build/cover-merged/
103104
mkdir -p acceptance/build/cover-merged/
104105
go tool covdata merge -i $$(printf '%s,' acceptance/build/cover/* | sed 's/,$$//') -o acceptance/build/cover-merged/

0 commit comments

Comments
 (0)