Revert "Resolve $resources refs before deployment if set by user" #3423 (#3443)

## Changes
- Do not do resolution before deployment, revert to let TF do that.
- Keep hasUpdates calculation and acceptance tests.

## Why
People might want to model depends_on relationship by introducing an
otherwise unnecessary reference.

Author: denik

acceptance/bundle/resource_deps/resources_var/out.deploy.direct-exp.txt

@@ -0,0 +1,7 @@
+
+>>> errcode [CLI] bundle deploy -t dev
+Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/dev/files...
+Error: reading config: failed to read references from config for pipelines.mypipeline: parsing refs: cannot process reference resources.volumes.foo.catalog_name: only ${resources.<group>.<key>.id} references are supported
+
+
+Exit code: 1

acceptance/bundle/resource_deps/resources_var/out.deploy.terraform.txt

@@ -0,0 +1,6 @@
+
+>>> errcode [CLI] bundle deploy -t dev
+Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/dev/files...
+Deploying resources...
+Updating deployment state...
+Deployment complete!

acceptance/bundle/resource_deps/resources_var/out.requests.direct-exp.txt

@@ -0,0 +1,2 @@
+
+>>> jq -s .[] | select(.path=="/api/2.0/pipelines") | .body.name out.requests.txt

acceptance/bundle/resource_deps/resources_var/out.requests.terraform.txt

@@ -0,0 +1,3 @@
+
+>>> jq -s .[] | select(.path=="/api/2.0/pipelines") | .body.name out.requests.txt
+"[dev [USERNAME]] pipeline for mycatalog.myschema.myname"

acceptance/bundle/resource_deps/resources_var/output.txt

@@ -32,12 +32,3 @@
     }
   }
 }
-
->>> [CLI] bundle deploy -t dev
-Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/dev/files...
-Deploying resources...
-Updating deployment state...
-Deployment complete!
-
->>> jq -s .[] | select(.path=="/api/2.0/pipelines") | .body.name out.requests.txt
-"[dev [USERNAME]] pipeline for mycatalog.myschema.myname"

acceptance/bundle/resource_deps/resources_var/script

@@ -1,4 +1,4 @@
 trace $CLI bundle validate -t dev -o json | jq .resources
-trace $CLI bundle deploy -t dev
-trace jq -s '.[] | select(.path=="/api/2.0/pipelines") | .body.name' out.requests.txt
+trace errcode $CLI bundle deploy -t dev &> out.deploy.$DATABRICKS_CLI_DEPLOYMENT.txt
+trace jq -s '.[] | select(.path=="/api/2.0/pipelines") | .body.name' out.requests.txt &> out.requests.$DATABRICKS_CLI_DEPLOYMENT.txt
 rm out.requests.txt

acceptance/bundle/resource_deps/resources_var/test.toml

@@ -1 +1,2 @@
+Badness = "direct does not work"
 RecordRequests = true

acceptance/bundle/resource_deps/resources_var_presets/out.test.toml

@@ -2,4 +2,4 @@ Local = true
 Cloud = false
 
 [EnvMatrix]
-  DATABRICKS_CLI_DEPLOYMENT = ["terraform", "direct-exp"]
+  DATABRICKS_CLI_DEPLOYMENT = ["terraform"]

acceptance/bundle/resource_deps/resources_var_presets/test.toml

@@ -1,4 +1,4 @@
 RecordRequests = true
 
-#EnvMatrix.DATABRICKS_CLI_DEPLOYMENT = ["terraform"]   # direct does not support non-id references yet
-# Error: reading config: failed to read references from config for volumes.foo: parsing refs: cannot process reference resources.schemas.bar.name: ${resources...} can only refer to field in the config or 'id'
+EnvMatrix.DATABRICKS_CLI_DEPLOYMENT = ["terraform"]   # direct does not support non-id references yet
+# Error: reading config: failed to read references from config for pipelines.mypipeline: parsing refs: cannot process reference resources.schemas.foo.catalog_name: only ${resources.<group>.<key>.id} references are supported

bundle/config/mutator/resolve_variable_references.go

@@ -229,22 +229,7 @@ func (m *resolveVariableReferences) resolveOnce(b *bundle.Bundle, prefixes []dyn
 				// Perform resolution only if the path starts with one of the specified prefixes.
 				for _, prefix := range prefixes {
 					if path.HasPrefix(prefix) {
-						isOpt := prefix[0].Key() == "resources"
-						var value dyn.Value
-						var err error
-						if isOpt {
-							// We don't want injected zero value when resolving $resources.
-							// We only want entries that are explicitly provided by users, so we're using root not normalized here.
-							value, err = m.lookupFn(root, path, b)
-							if !value.IsValid() {
-								// Not having a value is not an error in this case, it might be resolved at deploy time. For example, output only fields.
-								// TODO: we still could check whether it's part of the schema or not. If latter, we can reject it right away.
-								// TODO: This might be better done after we got rid of TF.
-								return dyn.InvalidValue, dynvar.ErrSkipResolution
-							}
-						} else {
-							value, err = m.lookupFn(normalized, path, b)
-						}
+						value, err := m.lookupFn(normalized, path, b)
 						hasUpdates = hasUpdates || (err == nil && value.IsValid())
 						return value, err
 					}