Skip to content

Commit 39c19d4

Browse files
committed
refactor: Remove unnecessary error discards from RegisterFlagCompletionFunc calls
1 parent 69b86c7 commit 39c19d4

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

cmd/root/bundle.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ func targetCompletion(cmd *cobra.Command, args []string, toComplete string) ([]s
146146
func initTargetFlag(cmd *cobra.Command) {
147147
// To operate in the context of a bundle, all commands must take an "target" parameter.
148148
cmd.PersistentFlags().StringP("target", "t", "", "bundle target to use (if applicable)")
149-
_ = cmd.RegisterFlagCompletionFunc("target", targetCompletion)
149+
cmd.RegisterFlagCompletionFunc("target", targetCompletion)
150150
}
151151

152152
// DEPRECATED flag

cmd/root/logger.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ func initLogFlags(cmd *cobra.Command) *logFlags {
104104
flags.MarkHidden("log-level")
105105
flags.MarkHidden("log-format")
106106

107-
_ = cmd.RegisterFlagCompletionFunc("log-file", f.file.Complete)
108-
_ = cmd.RegisterFlagCompletionFunc("log-level", f.level.Complete)
109-
_ = cmd.RegisterFlagCompletionFunc("log-format", f.output.Complete)
107+
cmd.RegisterFlagCompletionFunc("log-file", f.file.Complete)
108+
cmd.RegisterFlagCompletionFunc("log-level", f.level.Complete)
109+
cmd.RegisterFlagCompletionFunc("log-format", f.output.Complete)
110110
return &f
111111
}

cmd/root/progress_logger.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,6 @@ func initProgressLoggerFlag(cmd *cobra.Command, logFlags *logFlags) *progressLog
6565
flags := cmd.PersistentFlags()
6666
flags.Var(&f.ProgressLogFormat, "progress-format", "format for progress logs (append, inplace, json)")
6767
flags.MarkHidden("progress-format")
68-
_ = cmd.RegisterFlagCompletionFunc("progress-format", f.ProgressLogFormat.Complete)
68+
cmd.RegisterFlagCompletionFunc("progress-format", f.ProgressLogFormat.Complete)
6969
return &f
7070
}

0 commit comments

Comments
 (0)