Skip to content

Commit 4b1439b

Browse files
authored
feat: use library components (#4099)
## Changes <!-- Brief summary of your changes that is easy to understand --> Remove all shadcn components and consume them from `@databricks/appkit-ui/react` This [PR](databricks/appkit#2) would need to be merged first. ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> We reexport all the components from the library and provide a base theming, allowing users to easily customize the theme by simply changing the colors in the `index.css` file ## Tests <!-- How have you tested the changes? --> <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. --> Co-authored-by: MarioCadenas <[email protected]>
1 parent d79a4c2 commit 4b1439b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+696
-3691
lines changed

experimental/apps-mcp/templates/appkit/template/{{.project_name}}/CLAUDE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export const querySchemas = {
3838

3939
```typescript
4040
// client/src/App.tsx
41-
import { BarChart } from '@databricks/app-kit-ui/react';
41+
import { BarChart } from '@databricks/appkit-ui/react';
4242

4343
<BarChart queryKey="my_data" parameters={{}} />
4444
```
@@ -73,7 +73,7 @@ See the databricks experimental apps-mcp tools validate instead of running these
7373
**IMPORTANT**: Read the relevant docs below before implementing features. They contain critical information about common pitfalls (e.g., SQL numeric type handling, schema definitions, Radix UI constraints).
7474

7575
- [SQL Queries](docs/sql-queries.md) - query files, schemas, type handling, parameterization
76-
- [App Kit SDK](docs/app-kit-sdk.md) - TypeScript imports, server setup, useAnalyticsQuery hook
76+
- [App Kit SDK](docs/appkit-sdk.md) - TypeScript imports, server setup, useAnalyticsQuery hook
7777
- [Frontend](docs/frontend.md) - visualization components, styling, layout, Radix constraints
7878
- [tRPC](docs/trpc.md) - custom endpoints for non-SQL operations (mutations, Databricks APIs)
7979
- [Testing](docs/testing.md) - vitest unit tests, Playwright smoke/E2E tests

experimental/apps-mcp/templates/appkit/template/{{.project_name}}/client/src/App.tsx

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,22 @@
1-
import { useAnalyticsQuery, AreaChart, LineChart, RadarChart } from '@databricks/app-kit-ui/react';
2-
import { sql } from "@databricks/app-kit-ui/js";
1+
import {
2+
useAnalyticsQuery,
3+
AreaChart,
4+
LineChart,
5+
RadarChart,
6+
Card,
7+
CardContent,
8+
CardHeader,
9+
CardTitle,
10+
Skeleton,
11+
Label,
12+
Select,
13+
SelectContent,
14+
SelectItem,
15+
SelectTrigger,
16+
SelectValue,
17+
} from '@databricks/appkit-ui/react';
18+
import { sql } from "@databricks/appkit-ui/js";
319
import { Line, XAxis, YAxis, CartesianGrid, Tooltip } from 'recharts';
4-
import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card';
5-
import { Skeleton } from '@/components/ui/skeleton';
6-
import { Label } from '@/components/ui/label';
7-
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select';
820
import { trpc } from './lib/trpc';
921
import { useState, useEffect } from 'react';
1022

@@ -98,8 +110,8 @@ function App() {
98110
{health && (
99111
<div className="space-y-2">
100112
<div className="flex items-center gap-2">
101-
<div className="w-2 h-2 rounded-full bg-[hsl(var(--success))] animate-pulse"></div>
102-
<div className="text-lg font-semibold text-[hsl(var(--success))]">{health.status.toUpperCase()}</div>
113+
<div className="w-2 h-2 rounded-full bg-success animate-pulse"></div>
114+
<div className="text-lg font-semibold text-success">{health.status.toUpperCase()}</div>
103115
</div>
104116
<div className="text-sm text-muted-foreground">
105117
Last checked: {new Date(health.timestamp).toLocaleString()}

experimental/apps-mcp/templates/appkit/template/{{.project_name}}/client/src/ErrorBoundary.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React, { Component } from 'react';
22
import type { ReactNode } from 'react';
3-
import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card';
3+
import { Card, CardContent, CardHeader, CardTitle } from '@databricks/appkit-ui/react';
44

55
interface Props {
66
children: ReactNode;

experimental/apps-mcp/templates/appkit/template/{{.project_name}}/client/src/appKitTypes.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Auto-generated by AppKit - DO NOT EDIT
2-
import "@databricks/app-kit-ui/react";
2+
import "@databricks/appkit-ui/react";
33

4-
declare module "@databricks/app-kit-ui/react" {
4+
declare module "@databricks/appkit-ui/react" {
55
interface PluginRegistry {
66
"analytics": {
77
"/users/me/query/:query_key": {

experimental/apps-mcp/templates/appkit/template/{{.project_name}}/client/src/components/ui/accordion.tsx

Lines changed: 0 additions & 51 deletions
This file was deleted.

experimental/apps-mcp/templates/appkit/template/{{.project_name}}/client/src/components/ui/alert-dialog.tsx

Lines changed: 0 additions & 111 deletions
This file was deleted.

experimental/apps-mcp/templates/appkit/template/{{.project_name}}/client/src/components/ui/alert.tsx

Lines changed: 0 additions & 49 deletions
This file was deleted.

experimental/apps-mcp/templates/appkit/template/{{.project_name}}/client/src/components/ui/aspect-ratio.tsx

Lines changed: 0 additions & 7 deletions
This file was deleted.

experimental/apps-mcp/templates/appkit/template/{{.project_name}}/client/src/components/ui/avatar.tsx

Lines changed: 0 additions & 34 deletions
This file was deleted.

experimental/apps-mcp/templates/appkit/template/{{.project_name}}/client/src/components/ui/badge.tsx

Lines changed: 0 additions & 36 deletions
This file was deleted.

0 commit comments

Comments
 (0)