Skip to content

Commit 51e416d

Browse files
authored
Implement wsfix target to automatically fix whitespace issues (#3983)
## Changes * Add `wsfix` Makefile target and call it after codegen * Update all generated commands * Remove generated commands from `.wsignore` ## Why Whitespace issues cause unnecessary diffs.
1 parent 7904923 commit 51e416d

File tree

173 files changed

+1542
-1497
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

173 files changed

+1542
-1497
lines changed

.wsignore

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ acceptance/selftest/record_cloud/volume-io/hello.txt
2020
# bundle commands leave empty lines at the end; too many to list individually:
2121
acceptance/**/out*.txt
2222

23-
# Extra whitespace in generated commands:
24-
cmd/workspace/**/*.go
25-
cmd/account/**/*.go
26-
2723
# Extra whitespace in generated Python models
2824
python/databricks/bundles/*/_models/*.py
2925

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ tools/golangci-lint: tools/go.mod tools/go.sum
4646
ws:
4747
./tools/validate_whitespace.py
4848

49+
wsfix:
50+
./tools/validate_whitespace.py --fix
51+
4952
links:
5053
./tools/update_github_links.py
5154

@@ -147,4 +150,4 @@ generate:
147150
$(GENKIT_BINARY) update-sdk
148151

149152

150-
.PHONY: lint lintfull tidy lintcheck fmt fmtfull test cover showcover build snapshot snapshot-release schema integration integration-short acc-cover acc-showcover docs ws links checks test-update test-update-templates test-update-aws test-update-all generate-validation
153+
.PHONY: lint lintfull tidy lintcheck fmt fmtfull test cover showcover build snapshot snapshot-release schema integration integration-short acc-cover acc-showcover docs ws wsfix links checks test-update test-update-templates test-update-aws test-update-all generate-validation

cmd/account/access-control/access-control.go

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/account/billable-usage/billable-usage.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/account/budget-policy/budget-policy.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/account/budgets/budgets.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/account/credentials/credentials.go

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/account/csp-enablement-account/csp-enablement-account.go

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/account/custom-app-integration/custom-app-integration.go

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/account/disable-legacy-features/disable-legacy-features.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)