Skip to content

Commit 5e1d01e

Browse files
authored
Fix flaky TestHandover by increasing timeout to 500ms (#3749)
## Changes The 10ms handover timeout was too aggressive for the connection handover process, which involves creating new WebSocket connections, closing old ones, and waiting for acknowledgments. Changed to 500ms to allow reliable completion. ## Why Failure: https://github.com/databricks/cli/actions/runs/18462066531/job/52595573781
1 parent 246bfa5 commit 5e1d01e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

experimental/ssh/internal/proxy/client_server_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ func TestHandover(t *testing.T) {
144144
defer server.Close()
145145

146146
maxHandoverCount := 3
147-
handoverTimeout := 10 * time.Millisecond
147+
handoverTimeout := 500 * time.Millisecond
148148
createConnChan := make(chan error, 1)
149149
clientInputWriter, clientOutput := createTestClient(t, server.URL, handoverTimeout, nil, createConnChan)
150150
defer clientInputWriter.Close()

0 commit comments

Comments
 (0)