do not drop allow_duplicate_names field from the pipeline resource

Author: anton-107

NEXT_CHANGELOG.md

@@ -9,5 +9,6 @@
 ### CLI
 
 ### Bundles
+- Fixed an issue where `allow_duplicate_names` field on the pipeline definition was ignored by the bundle ([#3274](https://github.com/databricks/cli/pull/3274))
 
 ### API Changes

acceptance/bundle/deploy/pipeline/allow-duplicate-names/output.txt

@@ -2,24 +2,16 @@
 >>> [CLI] bundle deploy
 Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/acc-bundle-deploy-pipeline-duplicate-names-[UNIQUE_NAME]/default/files...
 Deploying resources...
-Error: terraform apply: exit status 1
-
-Error: cannot create pipeline: The pipeline name 'test-pipeline-same-name-[UNIQUE_NAME]' is already used by another pipeline. This check can be skipped by setting `allow_duplicate_names = true` in the request.
-
-  with databricks_pipeline.pipeline_one,
-  on bundle.tf.json line 30, in resource.databricks_pipeline.pipeline_one:
-  30:       }
-
-
-
 Updating deployment state...
+Deployment complete!
 
 >>> [CLI] bundle destroy --auto-approve
+The following resources will be deleted:
+  delete pipeline pipeline_one
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/acc-bundle-deploy-pipeline-duplicate-names-[UNIQUE_NAME]/default
 
 Deleting files...
 Destroy complete!
 
 >>> [CLI] pipelines delete [UUID]
-
-Exit code: 1

acceptance/bundle/deploy/pipeline/allow-duplicate-names/pipeline.json.tmpl

@@ -1,6 +1,5 @@
 {
     "name": "test-pipeline-same-name-$UNIQUE_NAME",
-    "allow_duplicate_names": true,
     "libraries": [
         {
             "file": {

acceptance/bundle/deploy/pipeline/allow-duplicate-names/test.toml

@@ -1,3 +1,2 @@
-Badness = "allow_duplicate_names field does not allow to create a pipeline with a duplicate name"
 Cloud = true
 Ignore = ["foo.py","pipeline.json"]

bundle/deploy/terraform/tfdyn/convert_pipeline.go

@@ -21,7 +21,7 @@ func convertPipelineResource(ctx context.Context, vin dyn.Value) (dyn.Value, err
 		return dyn.InvalidValue, err
 	}
 
-	vout, err = dyn.DropKeys(vout, []string{"allow_duplicate_names", "dry_run"})
+	vout, err = dyn.DropKeys(vout, []string{"dry_run"})
 	if err != nil {
 		return dyn.InvalidValue, err
 	}

bundle/internal/schema/main.go

@@ -115,7 +115,6 @@ func removePipelineFields(typ reflect.Type, s jsonschema.Schema) jsonschema.Sche
 		// Even though DABs supports this field, TF provider does not. Thus, we
 		// should not expose it to the user.
 		delete(s.Properties, "dry_run")
-		delete(s.Properties, "allow_duplicate_names")
 
 		// These fields are only meant to be set by the DABs client (ie the CLI)
 		// and thus should not be exposed to the user. These are used to annotate