Skip to content

Commit 7473e21

Browse files
acc: Add SkipOnDbr flag (#3527)
## Changes Certain tests would need to be skipped on DBR because of quirks in the workspace file system. This PR adds a flag to do so and disables artfic-related acceptance tests for now. ## Tests Manually, these tests were indeed skipped on runs.
1 parent 3ef7390 commit 7473e21

File tree

4 files changed

+34
-0
lines changed

4 files changed

+34
-0
lines changed

acceptance/acceptance_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,10 @@ func getSkipReason(config *internal.TestConfig, configPath string) string {
411411
return "Disabled via SkipLocal setting in " + configPath
412412
}
413413

414+
if isTruePtr(config.SkipOnDbr) && WorkspaceTmpDir {
415+
return "Disabled via SkipOnDbr setting in " + configPath
416+
}
417+
414418
if Forcerun {
415419
return ""
416420
}

acceptance/bundle/artifacts/test.toml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,18 @@
11
RecordRequests = true
2+
3+
# Workspace file system does not allow initializing python envs on it.
4+
# I suspect something about the default python env on DBR interferes with it.
5+
# We'll likely need a first class venv abstraction in acceptance tests to fix this.
6+
# script:
7+
# uv venv -q .venv
8+
# source .venv/bin/activate
9+
# uv pip install -q setuptools
10+
# error:
11+
# Failed to inspect Python interpreter from active virtual environment at `.venv/bin/python3`
12+
# Caused by: Failed to query Python interpreter
13+
# Caused by: failed to canonicalize path `/Workspace/abcd/.venv/bin/python3`: Invalid cross-device link (os error 18)
14+
SkipOnDbr = true
15+
216
Ignore = [
317
'.venv',
418
'dist',

acceptance/bundle/integration_whl/test.toml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,19 @@
11
Local = false
22
CloudSlow = true
33

4+
# Workspace file system does not allow initializing python envs on it.
5+
# I suspect something about the default python env on DBR interferes with it.
6+
# We'll likely need a first class venv abstraction in acceptance tests to fix this.
7+
# script:
8+
# uv venv -q .venv
9+
# source .venv/bin/activate
10+
# uv pip install -q setuptools
11+
# error:
12+
# Failed to inspect Python interpreter from active virtual environment at `.venv/bin/python3`
13+
# Caused by: Failed to query Python interpreter
14+
# Caused by: failed to canonicalize path `/Workspace/abcd/.venv/bin/python3`: Invalid cross-device link (os error 18)
15+
SkipOnDbr = true
16+
417
Ignore = [
518
".databricks",
619
".venv",

acceptance/internal/config.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,9 @@ type TestConfig struct {
131131
// Null means "databricks.yml"
132132
BundleConfigTarget *string
133133

134+
// If true, skip this test when running on DBR / workspace file system.
135+
SkipOnDbr *bool
136+
134137
// To be added:
135138
// BundleConfigMatrix is to BundleConfig what EnvMatrix is to Env
136139
// It creates different tests for each possible configuration update.

0 commit comments

Comments
 (0)