Enable linter for exhaustive coverage in enum switch statements (#3641)

## Changes

Linter will error for switch statements on an enum where not all enum
values are covered.

The statement can still use a `default:` clause to explicitly fall
through.

## Why

Observation here:
#3546 (comment)

Author: pietern

.golangci.yaml

@@ -15,6 +15,7 @@ linters:
     - unconvert
     - unused
     - exhaustruct
+    - exhaustive
     - copyloopvar
     - forbidigo
   settings:
@@ -59,6 +60,8 @@ linters:
         - len
         - equal-values
         - encoded-compare # Always replaces Equal() with JSONEq, but sometimes exact string match is wanted for JSON
+    exhaustive:
+      default-signifies-exhaustive: true
   exclusions:
     generated: lax
     presets:

bundle/config/mutator/sync_default_path.go

@@ -26,8 +26,7 @@ func (m *syncDefaultPath) Apply(ctx context.Context, b *bundle.Bundle) diag.Diag
 
 		// If the sync paths field is already set, do nothing.
 		// We know it is set if its value is either a nil or a sequence (empty or not).
-		switch pv.Kind() {
-		case dyn.KindNil, dyn.KindSequence:
+		if pv.Kind() == dyn.KindNil || pv.Kind() == dyn.KindSequence {
 			isset = true
 		}
 

bundle/run/job.go

@@ -235,6 +235,9 @@ func (r *jobRunner) Run(ctx context.Context, opts *Options) (output.RunOutput, e
 	case jobs.RunResultStateTimedout:
 		log.Infof(ctx, "Run has timed out!")
 		return nil, fmt.Errorf("run timed out: %s", run.State.StateMessage)
+
+	// TODO: handle other result states.
+	default:
 	}
 
 	return nil, err

cmd/labs/project/installer_test.go

@@ -297,13 +297,15 @@ func TestInstallerWorksForDevelopment(t *testing.T) {
 					{
 						ClusterId:        "abc-id",
 						ClusterName:      "first shared",
+						ClusterSource:    compute.ClusterSourceApi,
 						DataSecurityMode: compute.DataSecurityModeUserIsolation,
 						SparkVersion:     "12.2.x-whatever",
 						State:            compute.StateRunning,
 					},
 					{
 						ClusterId:        "bcd-id",
 						ClusterName:      "second personal",
+						ClusterSource:    compute.ClusterSourceApi,
 						DataSecurityMode: compute.DataSecurityModeSingleUser,
 						SparkVersion:     "14.5.x-whatever",
 						State:            compute.StateRunning,

cmd/sync/completion.go

@@ -28,8 +28,7 @@ func fetchDirs(ctx context.Context, wsc *databricks.WorkspaceClient, path string
 		// We're interested only in paths we can sync to.
 		var dirs []string
 		for _, file := range files {
-			switch file.ObjectType {
-			case workspace.ObjectTypeDirectory, workspace.ObjectTypeRepo:
+			if file.ObjectType == workspace.ObjectTypeDirectory || file.ObjectType == workspace.ObjectTypeRepo {
 				dirs = append(dirs, file.Path)
 			}
 		}

libs/databrickscfg/cfgpickers/clusters.go

@@ -98,19 +98,19 @@ func (v compatibleCluster) State() string {
 
 type clusterFilter func(cluster *compute.ClusterDetails, me *iam.User) bool
 
+// Filter function to check if a cluster is created through the UI or an API call.
+func isUsableCluster(cluster *compute.ClusterDetails) bool {
+	return cluster.ClusterSource == compute.ClusterSourceUi || cluster.ClusterSource == compute.ClusterSourceApi
+}
+
 func WithDatabricksConnect(minVersion string) func(*compute.ClusterDetails, *iam.User) bool {
 	return func(cluster *compute.ClusterDetails, me *iam.User) bool {
 		if !IsCompatibleWithUC(*cluster, minVersion) {
 			return false
 		}
-		switch cluster.ClusterSource {
-		case compute.ClusterSourceJob,
-			compute.ClusterSourceModels,
-			compute.ClusterSourcePipeline,
-			compute.ClusterSourcePipelineMaintenance,
-			compute.ClusterSourceSql:
-			// only UI and API clusters are usable for DBConnect.
-			// `CanUseClient: "NOTEBOOKS"`` didn't seem to have an effect.
+		// Only clusters created through the UI or an API call are usable for DBConnect.
+		// `CanUseClient: "NOTEBOOKS"`` didn't seem to have an effect.
+		if !isUsableCluster(cluster) {
 			return false
 		}
 		if cluster.SingleUserName != "" && cluster.SingleUserName != me.UserName {
@@ -124,11 +124,7 @@ func WithDatabricksConnect(minVersion string) func(*compute.ClusterDetails, *iam
 // It does this by keeping only clusters created through the UI or an API call.
 func WithoutSystemClusters() func(*compute.ClusterDetails, *iam.User) bool {
 	return func(cluster *compute.ClusterDetails, me *iam.User) bool {
-		switch cluster.ClusterSource {
-		case compute.ClusterSourceApi, compute.ClusterSourceUi:
-			return true
-		}
-		return false
+		return isUsableCluster(cluster)
 	}
 }
 

libs/databrickscfg/cfgpickers/clusters_test.go

@@ -74,13 +74,15 @@ func TestFirstCompatibleCluster(t *testing.T) {
 					{
 						ClusterId:        "abc-id",
 						ClusterName:      "first shared",
+						ClusterSource:    compute.ClusterSourceApi,
 						DataSecurityMode: compute.DataSecurityModeUserIsolation,
 						SparkVersion:     "12.2.x-whatever",
 						State:            compute.StateRunning,
 					},
 					{
 						ClusterId:        "bcd-id",
 						ClusterName:      "second personal",
+						ClusterSource:    compute.ClusterSourceUi,
 						DataSecurityMode: compute.DataSecurityModeSingleUser,
 						SparkVersion:     "14.5.x-whatever",
 						State:            compute.StateRunning,

libs/diag/diagnostic.go

@@ -77,16 +77,6 @@ func Warningf(format string, args ...any) Diagnostics {
 	}
 }
 
-// Infof creates a new info diagnostic.
-func Infof(format string, args ...any) Diagnostics {
-	return []Diagnostic{
-		{
-			Severity: Info,
-			Summary:  fmt.Sprintf(format, args...),
-		},
-	}
-}
-
 // Recommendationf creates a new recommendation diagnostic.
 func Recommendationf(format string, args ...any) Diagnostics {
 	return []Diagnostic{

libs/diag/severity.go

@@ -5,6 +5,5 @@ type Severity int
 const (
 	Error Severity = iota
 	Warning
-	Info
 	Recommendation
 )

libs/dyn/convert/from_typed.go

@@ -255,6 +255,8 @@ func fromTypedString(src reflect.Value, ref dyn.Value, options ...fromTypedOptio
 			return dyn.NilValue, nil
 		}
 		return dyn.V(src.String()), nil
+	default:
+		// Fall through to the error case.
 	}
 
 	return dyn.InvalidValue, fmt.Errorf("cannot convert string field to dynamic type %#v: src=%#v ref=%#v", ref.Kind().String(), src, ref.AsAny())
@@ -280,6 +282,8 @@ func fromTypedBool(src reflect.Value, ref dyn.Value, options ...fromTypedOptions
 		if dynvar.IsPureVariableReference(ref.MustString()) {
 			return ref, nil
 		}
+	default:
+		// Fall through to the error case.
 	}
 
 	return dyn.InvalidValue, fmt.Errorf("cannot convert bool field to dynamic type %#v: src=%#v ref=%#v", ref.Kind().String(), src, ref.AsAny())
@@ -305,6 +309,8 @@ func fromTypedInt(src reflect.Value, ref dyn.Value, options ...fromTypedOptions)
 		if dynvar.IsPureVariableReference(ref.MustString()) {
 			return ref, nil
 		}
+	default:
+		// Fall through to the error case.
 	}
 
 	return dyn.InvalidValue, fmt.Errorf("cannot convert int field to dynamic type %#v: src=%#v ref=%#v", ref.Kind().String(), src, ref.AsAny())
@@ -330,6 +336,8 @@ func fromTypedFloat(src reflect.Value, ref dyn.Value, options ...fromTypedOption
 		if dynvar.IsPureVariableReference(ref.MustString()) {
 			return ref, nil
 		}
+	default:
+		// Fall through to the error case.
 	}
 
 	return dyn.InvalidValue, fmt.Errorf("cannot convert float field to dynamic type %#v: src=%#v ref=%#v", ref.Kind().String(), src, ref.AsAny())