Upgrade Go to 1.25.1 (#3575)

## Changes

Changelog: https://tip.golang.org/doc/go1.25

* Fix one acceptance test on Windows due to a changed error message.
* Bump golangci-lint to v2.4.0 (must be built with the same Go minor
version).

## Why

[`testing/synctest` is finally
here!](https://tip.golang.org/doc/go1.25#new-testingsynctest-package)

---------

Co-authored-by: Pieter Noordhuis <[email protected]>

Author: ilia-db

.github/workflows/push.yml

@@ -118,7 +118,7 @@ jobs:
       - name: Run Go lint checks (does not include formatting checks)
         uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0
         with:
-          version: v2.1.6
+          version: v2.4.0
           args: --timeout=15m
       - name: Run ruff (Python linter and formatter)
         uses: astral-sh/ruff-action@0c50076f12c38c3d0115b7b519b54a91cb9cf0ad # v3.5.0

acceptance/bundle/paths/pipeline_root_path_doesnotexist/test.toml

@@ -1,4 +1,4 @@
 # Replace error message from windows
 [[Repls]]
-Old = "CreateFile foo/bar/doesnotexist: The system cannot find the path specified."
+Old = "GetFileAttributesEx foo/bar/doesnotexist: The system cannot find the path specified."
 New = "stat foo/bar/doesnotexist: no such file or directory"

acceptance/internal/prepare_server.go

@@ -31,8 +31,27 @@ func StartDefaultServer(t *testing.T) {
 
 	t.Setenv("DATABRICKS_DEFAULT_HOST", s.URL)
 
-	// Do not read user's ~/.databrickscfg
-	homeDir := t.TempDir()
+	// Do not read user's ~/.databrickscfg.
+	//
+	// We use a custom temporary home directory and cleanup routine here to avoid
+	// issues observed with t.TempDir() on Windows, where Go 1.25's test cleanup
+	// can fail to remove certain directories (e.g., due to locked or system-managed files).
+	// Instead of failing the test, we log any errors encountered during cleanup.
+	// This approach ensures test reliability across platforms.
+	//
+	// See debugging journey in https://github.com/databricks/cli/pull/3575.
+	homeDir, err := os.MkdirTemp("", "acceptance-home-dir")
+	require.NoError(t, err)
+	t.Cleanup(func() {
+		err := os.RemoveAll(homeDir)
+		if err != nil {
+			t.Logf("Failed to remove temporary home directory: %v", err)
+			_ = filepath.Walk(homeDir, func(path string, info os.FileInfo, err error) error {
+				t.Logf("%s", path)
+				return nil
+			})
+		}
+	})
 	t.Setenv(env.HomeEnvVar(), homeDir)
 }
 

go.mod

@@ -1,8 +1,8 @@
 module github.com/databricks/cli
 
-go 1.24.0
+go 1.25.0
 
-toolchain go1.24.6
+toolchain go1.25.1
 
 require (
 	dario.cat/mergo v1.0.2 // BSD 3-Clause