Skip to content

Commit 85537b5

Browse files
Downgrade load git info failure to info logs (#3499)
## Why The warnings leak into the acceptance tests' output when the tests are run on the workspace file system. This warning is not expected to show up if the tests were run on Git folders instead. While some integration tests will need to be run on Git Folders, the plan is to run integration tests on the workspace file system by default. This is because Git folders are: 1. Slightly complex and time-consuming to set up (they need to be backed by a real repository). 2. Historically, the repos API has been a source of flakiness. 3. Repos functionality is unnecessary for most integration test assertions we perform in our acceptance tests. The only place it is relevant is when loading Git metadata. I plan to create a separate test for that.
1 parent 3fd8376 commit 85537b5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

libs/git/info.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ func fetchRepositoryInfoAPI(ctx context.Context, path string, w *databricks.Work
8686
result.CurrentBranch = gi.Branch
8787
result.WorktreeRoot = fixedPath
8888
} else {
89-
log.Warnf(ctx, "Failed to load git info from %s", apiEndpoint)
89+
log.Infof(ctx, "Failed to load git info from %s", apiEndpoint)
9090
}
9191

9292
return result, nil

0 commit comments

Comments
 (0)