Skip to content

Commit 8b7f506

Browse files
authored
Increase SDK timeout from 30s to 90s (#3550)
## Changes - Increase HTTPTimeoutSeconds from 30s to 90s - Increase RetryTimeoutSeconds from 5m to 15m ## Why We saw an issue where "bundle deploy" dies during upload of 1.4Mb file with "request timed out after 30s of inactivity". We'd rather see the backend raise the error. ## Tests New test that records what happens during timeout. Incidentally it shows that retries do not work. Another test shows what happens for 500, just for completeness.
1 parent d543fc7 commit 8b7f506

File tree

14 files changed

+62
-0
lines changed

14 files changed

+62
-0
lines changed

.wsignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ integration/bundle/testdata/apps/bundle_deploy.txt
3030

3131
# Extra whitespace in test output:
3232
acceptance/bundle/resource_deps/bad_syntax/out.plan.terraform.txt
33+
acceptance/bundle/upload/internal_server_error/output.txt
3334

3435
# Extra whitespace in command help:
3536
acceptance/cmd/workspace/apps/output.txt
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
bundle:
2+
name: test-bundle
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
hello
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Local = true
2+
Cloud = false
3+
4+
[EnvMatrix]
5+
DATABRICKS_CLI_DEPLOYMENT = ["terraform", "direct-exp"]
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
2+
Error: Internal Server Error (500)
3+
4+
Endpoint: POST [DATABRICKS_URL]/api/2.0/workspace-files/import-file/Workspace%2FUsers%2F[USERNAME]%2F.bundle%2Ftest-bundle%2Fdefault%2Ffiles%2Ffile_to_upload.txt?overwrite=true
5+
HTTP Status: 500 Internal Server Error
6+
API error_code:
7+
API message: Internal Server Error
8+
9+
10+
Exit code (musterr): 1
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
musterr $CLI bundle deploy
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
[[Server]]
2+
Pattern = "POST /api/2.0/workspace-files/import-file/Workspace/Users/[email protected]/.bundle/test-bundle/default/files/file_to_upload.txt"
3+
Response.StatusCode = 500
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
bundle:
2+
name: test-bundle
3+
4+
sync:
5+
include:
6+
- files_to_upload.txt
7+
exclude:
8+
- "out*"
9+
- "test.toml"
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
hello
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Local = true
2+
Cloud = false
3+
4+
[EnvMatrix]
5+
DATABRICKS_CLI_DEPLOYMENT = ["terraform", "direct-exp"]

0 commit comments

Comments
 (0)