Commit 995a4c6
authored
rm terraform.Interpolate() and terraform.Write() from bundle run (#3169)
## Why
These are terraform-specific but not necessary for "bundle run":
- terraform.Interpolate: modifies bundle in-place references like
resources.jobs.foo.id are replaced with tf-specific references.
- terraform.Write: converts in-memory bundle config to terraform format
and saves as bundle.tf.json.
None of the follow up mutators depend on the above, read bundle.tf.json:
- statemgmt.StatePull() downloads state from remote.
- statemgmt.Load() merges ids from state file into bundle config and
updates modified_status as well/
- bundle/run/* does not depend on terraform as well.
Context: https://github.com/databricks/cli/pull/288/files#r2180107197
## Tests
Existing tests: acceptance/bundle/run, acceptance/bundle/integration_whl
Additional test to see that state is pulled correctly:
acceptance/bundle/run/state-wiped1 parent 062062d commit 995a4c6
File tree
6 files changed
+56
-12
lines changed- acceptance/bundle/run/state-wiped
- cmd/bundle
6 files changed
+56
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
Whitespace-only changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
| |||
167 | 166 | | |
168 | 167 | | |
169 | 168 | | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | 169 | | |
182 | 170 | | |
183 | 171 | | |
| |||
0 commit comments