Skip to content

Commit a49a0ee

Browse files
committed
Merge remote-tracking branch 'origin/main' into default-catalog-schema
2 parents 22391a8 + 2141440 commit a49a0ee

File tree

344 files changed

+2574
-206
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

344 files changed

+2574
-206
lines changed

.codegen/_openapi_sha

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8b2cd47cbac64b32e120601110a5fc70b8189ba4
1+
e1ea3f5ba0bc5b53be94f56535a67ba701a52a52

Makefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,10 @@ test-update:
8787
test-update-templates:
8888
-go test ./acceptance -run '^TestAccept/bundle/templates' -update -timeout=${LOCAL_TIMEOUT}
8989

90+
# Regenerate out.test.toml files without running tests
91+
generate-out-test-toml:
92+
go test ./acceptance -run '^TestAccept$$' -only-out-test-toml -timeout=${LOCAL_TIMEOUT}
93+
9094
# Updates acceptance test output (integration tests, requires access)
9195
test-update-aws:
9296
deco env run -i -n aws-prod-ucws -- go test ./acceptance -run ^TestAccept$$ -update -timeout=1h -skiplocal -v
@@ -167,7 +171,7 @@ generate:
167171
$(GENKIT_BINARY) update-sdk
168172

169173

170-
.PHONY: lint lintfull tidy lintcheck fmt fmtfull test test-unit test-acc test-slow test-slow-unit test-slow-acc cover showcover build snapshot snapshot-release schema integration integration-short acc-cover acc-showcover docs ws wsfix links checks test-update test-update-templates test-update-aws test-update-all generate-validation
174+
.PHONY: lint lintfull tidy lintcheck fmt fmtfull test test-unit test-acc test-slow test-slow-unit test-slow-acc cover showcover build snapshot snapshot-release schema integration integration-short acc-cover acc-showcover docs ws wsfix links checks test-update test-update-templates generate-out-test-toml test-update-aws test-update-all generate-validation
171175

172176
test-exp-aitools:
173177
make test TEST_PACKAGES="./experimental/aitools/..." ACCEPTANCE_TEST_FILTER="TestAccept/idontexistyet/aitools"

NEXT_CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@
77
### CLI
88

99
### Bundles
10+
* engine/direct: Fix dependency-ordered deletion by persisting depends_on in state ([#4105](https://github.com/databricks/cli/pull/4105))
11+
* Pass SYSTEM_ACCESSTOKEN from env to the Terraform provider ([#4135](https://github.com/databricks/cli/pull/4135)
1012

1113
### Dependency updates
14+
* Upgrade Go SDK to 0.94.0 ([#4148](https://github.com/databricks/cli/pull/4148))
15+
* Upgrade Terraform provider to 1.100.0 ([#4150](https://github.com/databricks/cli/pull/4150))
1216

1317
### API Changes

acceptance/acceptance_test.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ var (
4848
UseVersion string
4949
WorkspaceTmpDir bool
5050
TerraformDir string
51+
OnlyOutTestToml bool
5152
)
5253

5354
// In order to debug CLI running under acceptance test, search for TestInprocessMode and update
@@ -78,6 +79,7 @@ func init() {
7879
// creates these symlinks when a file_mirror is used for a provider (in .terraformrc). This flag
7980
// allows us to download the provider to the workspace file system on DBR enabling DBR integration testing.
8081
flag.StringVar(&TerraformDir, "terraform-dir", "", "Directory to download the terraform provider to")
82+
flag.BoolVar(&OnlyOutTestToml, "only-out-test-toml", false, "Only regenerate out.test.toml files without running tests")
8183
}
8284

8385
const (
@@ -307,14 +309,19 @@ func testAccept(t *testing.T, inprocessMode bool, singleTest string) int {
307309
config, configPath := internal.LoadConfig(t, dir)
308310
skipReason := getSkipReason(&config, configPath)
309311

310-
if testdiff.OverwriteMode {
312+
if testdiff.OverwriteMode || OnlyOutTestToml {
311313
// Generate materialized config for this test
312314
// We do this before skipping the test, so the configs are generated for all tests.
313315
materializedConfig, err := internal.GenerateMaterializedConfig(config)
314316
require.NoError(t, err)
315317
testutil.WriteFile(t, filepath.Join(dir, internal.MaterializedConfigFile), materializedConfig)
316318
}
317319

320+
// If only regenerating out.test.toml, skip the actual test execution
321+
if OnlyOutTestToml {
322+
t.Skip("Skipping test execution (only regenerating out.test.toml)")
323+
}
324+
318325
if skipReason != "" {
319326
skippedDirs += 1
320327
t.Skip(skipReason)

acceptance/bundle/artifacts/whl_dynamic/out.plan_create.direct.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
{
2+
"plan_version": 1,
3+
"cli_version": "[DEV_VERSION]",
24
"plan": {
35
"resources.jobs.test_job": {
46
"action": "create",

acceptance/bundle/artifacts/whl_dynamic/out.plan_create.terraform.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
{
2+
"plan_version": 1,
3+
"cli_version": "[DEV_VERSION]",
24
"plan": {
35
"resources.jobs.test_job": {
46
"action": "create"

acceptance/bundle/artifacts/whl_dynamic/out.plan_update.direct.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
{
2+
"plan_version": 1,
3+
"cli_version": "[DEV_VERSION]",
24
"plan": {
35
"resources.jobs.test_job": {
46
"action": "update",

acceptance/bundle/artifacts/whl_dynamic/out.plan_update.terraform.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
{
2+
"plan_version": 1,
3+
"cli_version": "[DEV_VERSION]",
24
"plan": {
35
"resources.jobs.test_job": {
46
"action": "update"

acceptance/bundle/migrate/basic/out.new_state.json

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
{
2+
"state_version": 1,
3+
"cli_version": "[DEV_VERSION]",
24
"lineage": "[UUID]",
35
"serial": 6,
46
"state": {
@@ -51,7 +53,33 @@
5153
"volume_catalog_name": "mycat",
5254
"volume_storage_location": "s3://deco-uc-prod-isolated-aws-us-east-1/metastore/[UUID]/volumes/[UUID]"
5355
}
54-
}
56+
},
57+
"depends_on": [
58+
{
59+
"node": "resources.jobs.test_job",
60+
"label": "${resources.jobs.test_job.id}"
61+
},
62+
{
63+
"node": "resources.jobs.test_job",
64+
"label": "${resources.jobs.test_job.name}"
65+
},
66+
{
67+
"node": "resources.jobs.test_job",
68+
"label": "${resources.jobs.test_job.timeout_seconds}"
69+
},
70+
{
71+
"node": "resources.volumes.test_volume",
72+
"label": "${resources.volumes.test_volume.catalog_name}"
73+
},
74+
{
75+
"node": "resources.volumes.test_volume",
76+
"label": "${resources.volumes.test_volume.id}"
77+
},
78+
{
79+
"node": "resources.volumes.test_volume",
80+
"label": "${resources.volumes.test_volume.storage_location}"
81+
}
82+
]
5583
},
5684
"resources.volumes.test_volume": {
5785
"__id__": "mycat.myschema.myvol",

acceptance/bundle/migrate/basic/out.plan_update.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
{
2+
"plan_version": 1,
3+
"cli_version": "[DEV_VERSION]",
24
"plan": {
35
"resources.jobs.test_job": {
46
"action": "update",

0 commit comments

Comments
 (0)