Fix lakeview publish to default embed_credentials to false

Author: varundeepsaini

acceptance/bundle/deploy/fail-on-active-runs/out.test.toml

@@ -1,8 +1,5 @@
 RecordRequests = true
 
-# --fail-on-active-runs not implemented yet
-EnvMatrix.DATABRICKS_BUNDLE_ENGINE = ["terraform"]
-
 [[Server]]
 Pattern = "GET /api/2.2/jobs/runs/list"
 Response.Body = '''

acceptance/bundle/deploy/fail-on-active-runs/test.toml

@@ -1,6 +1,3 @@
-# Deploy relies on terraform.CheckRunningResource()
-EnvMatrix.DATABRICKS_BUNDLE_ENGINE = ["terraform"]
-
 # Cycling between states not implemented yet
 # spec to avoid "pipeline spec is nil" error
 

acceptance/pipelines/deploy/fail-on-active-runs/out.test.toml

@@ -1,6 +1,22 @@
 {
   "method": "POST",
-  "path": "/api/2.0/lakeview/dashboards/dashboard-id-123/published",
+  "path": "/api/2.0/workspace/mkdirs",
+  "body": {
+    "path": "/Users/[USERNAME]"
+  }
+}
+{
+  "method": "POST",
+  "path": "/api/2.0/lakeview/dashboards",
+  "body": {
+    "display_name": "Test Dashboard",
+    "parent_path": "/Users/[USERNAME]",
+    "warehouse_id": "test-warehouse"
+  }
+}
+{
+  "method": "POST",
+  "path": "/api/2.0/lakeview/dashboards/[DASHBOARD_ID]/published",
   "body": {
     "embed_credentials": false
   }

acceptance/pipelines/deploy/fail-on-active-runs/test.toml

@@ -1,8 +1,7 @@
 
->>> [CLI] lakeview publish dashboard-id-123
+>>> [CLI] lakeview publish [DASHBOARD_ID]
 {
-  "display_name":"My Dashboard",
+  "display_name":"Test Dashboard",
   "embed_credentials":false,
-  "revision_create_time":"[TIMESTAMP]",
-  "warehouse_id":"warehouse-123"
+  "warehouse_id":"test-warehouse"
 }

acceptance/workspace/lakeview/publish/out.requests.txt

@@ -1,2 +1,5 @@
-# Test that embed_credentials defaults to false when --embed-credentials flag is not provided
-trace $CLI lakeview publish dashboard-id-123
+$CLI workspace mkdirs /Users/[email protected]
+
+dashboard_id=$($CLI lakeview create --json '{"display_name": "Test Dashboard", "parent_path": "/Users/[email protected]", "warehouse_id": "test-warehouse"}' -o json | jq -r '.dashboard_id')
+
+trace $CLI lakeview publish $dashboard_id

acceptance/workspace/lakeview/publish/output.txt

@@ -1,13 +1,5 @@
 RecordRequests = true
 
-[[Server]]
-Pattern = "POST /api/2.0/lakeview/dashboards/dashboard-id-123/published"
-Response.Body = '''
-{
-    "dashboard_id": "dashboard-id-123",
-    "display_name": "My Dashboard",
-    "warehouse_id": "warehouse-123",
-    "embed_credentials": false,
-    "revision_create_time": "2025-01-01T00:00:00.000Z"
-}
-'''
+[[Repls]]
+Old = "[a-f0-9]{32}"
+New = "[DASHBOARD_ID]"

acceptance/workspace/lakeview/publish/script

@@ -12,6 +12,7 @@ import (
 	"github.com/databricks/cli/bundle/deploy/terraform"
 	"github.com/databricks/cli/bundle/deployplan"
 	"github.com/databricks/cli/bundle/libraries"
+	"github.com/databricks/cli/bundle/statemgmt"
 	"github.com/databricks/cli/bundle/trampoline"
 	"github.com/databricks/cli/libs/dyn"
 	"github.com/databricks/cli/libs/logdiag"
@@ -24,7 +25,7 @@ func DeployPrepare(ctx context.Context, b *bundle.Bundle, isPlan bool, engine en
 		terraform.CheckDashboardsModifiedRemotely(isPlan, engine),
 		deploy.StatePull(),
 		mutator.ValidateGitDetails(),
-		terraform.CheckRunningResource(),
+		statemgmt.CheckRunningResource(engine),
 
 		// libraries.CheckForSameNameLibraries() needs to be run after we expand glob references so we
 		// know what are the actual library paths.

acceptance/workspace/lakeview/publish/test.toml

@@ -1,4 +1,4 @@
-package terraform
+package statemgmt
 
 import (
 	"context"
@@ -7,6 +7,8 @@ import (
 
 	"github.com/databricks/cli/bundle"
 	"github.com/databricks/cli/bundle/config"
+	"github.com/databricks/cli/bundle/config/engine"
+	"github.com/databricks/cli/bundle/deploy/terraform"
 	"github.com/databricks/cli/libs/diag"
 	"github.com/databricks/databricks-sdk-go"
 	"github.com/databricks/databricks-sdk-go/service/jobs"
@@ -23,7 +25,9 @@ func (e ErrResourceIsRunning) Error() string {
 	return fmt.Sprintf("%s %s is running", e.resourceType, e.resourceId)
 }
 
-type checkRunningResources struct{}
+type checkRunningResources struct {
+	engine engine.EngineType
+}
 
 func (l *checkRunningResources) Name() string {
 	return "check-running-resources"
@@ -34,9 +38,20 @@ func (l *checkRunningResources) Apply(ctx context.Context, b *bundle.Bundle) dia
 		return nil
 	}
 
-	state, err := ParseResourcesState(ctx, b)
-	if err != nil && state == nil {
-		return diag.FromErr(err)
+	var err error
+	var state ExportedResourcesMap
+
+	if l.engine.IsDirect() {
+		_, fullPathDirect := b.StateFilenameDirect(ctx)
+		state, err = b.DeploymentBundle.ExportState(ctx, fullPathDirect)
+		if err != nil {
+			return diag.FromErr(err)
+		}
+	} else {
+		state, err = terraform.ParseResourcesState(ctx, b)
+		if err != nil {
+			return diag.FromErr(err)
+		}
 	}
 
 	w := b.WorkspaceClient()
@@ -47,8 +62,8 @@ func (l *checkRunningResources) Apply(ctx context.Context, b *bundle.Bundle) dia
 	return nil
 }
 
-func CheckRunningResource() *checkRunningResources {
-	return &checkRunningResources{}
+func CheckRunningResource(engine engine.EngineType) bundle.Mutator {
+	return &checkRunningResources{engine: engine}
 }
 
 func checkAnyResourceRunning(ctx context.Context, w *databricks.WorkspaceClient, state ExportedResourcesMap) error {