make things work on windows

Author: nfx

libs/python/detect_test.go renamed to libs/python/detect_unix_test.go

@@ -1,3 +1,5 @@
+//go:build unix
+
 package python
 
 import (

libs/python/detect_win_test.go

@@ -0,0 +1,24 @@
+//go:build windows
+
+package python
+
+import (
+	"context"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestDetectsViaWhich(t *testing.T) {
+	ctx := context.Background()
+	py, err := DetectExecutable(ctx)
+	assert.NoError(t, err)
+	assert.NotEmpty(t, py)
+}
+
+func TestDetectFailsNoInterpreters(t *testing.T) {
+	t.Setenv("PATH", "testdata")
+	ctx := context.Background()
+	_, err := DetectExecutable(ctx)
+	assert.ErrorIs(t, err, ErrNoPythonInterpreters)
+}

libs/python/interpreters.go

@@ -7,6 +7,7 @@ import (
 	"io/fs"
 	"os"
 	"path/filepath"
+	"runtime"
 	"sort"
 	"strings"
 
@@ -47,6 +48,9 @@ func (a allInterpreters) AtLeast(minimalVersion string) (*Interpreter, error) {
 
 var ErrNoPythonInterpreters = errors.New("no python3 interpreters found")
 
+const officialMswinPython = "(Python Official) https://www.python.org/downloads/windows"
+const microsoftStorePython = "(Microsoft Store) https://apps.microsoft.com/store/search?publisher=Python%20Software%20Foundation"
+
 const worldWriteable = 0o002
 
 func DetectInterpreters(ctx context.Context) (allInterpreters, error) {
@@ -70,7 +74,8 @@ func DetectInterpreters(ctx context.Context) (allInterpreters, error) {
 			continue
 		}
 		perm := info.Mode().Perm()
-		if perm&worldWriteable != 0 {
+		xx := runtime.GOOS
+		if xx != "windows" && perm&worldWriteable != 0 {
 			// we try not to run any python binary that sits in a writable folder by all users.
 			// this is mainly to avoid breaking the security model on a multi-user system.
 			// If the PATH is pointing somewhere untrusted it is the user fault, but we can
@@ -119,7 +124,15 @@ func DetectInterpreters(ctx context.Context) (allInterpreters, error) {
 
 			// probe the binary version by executing it, like `python --version`
 			// and parsing the output.
+			//
+			// Keep in mind, that mswin installations get python.exe and pythonw.exe,
+			// which are slightly different: see https://stackoverflow.com/a/30313091
 			out, err := process.Background(ctx, []string{resolved, "--version"})
+			var processErr *process.ProcessError
+			if errors.As(err, &processErr) {
+				log.Debugf(ctx, "failed to check version for %s: %s", resolved, processErr.Err)
+				continue
+			}
 			if err != nil {
 				log.Debugf(ctx, "failed to check version for %s: %s", resolved, err)
 				continue
@@ -158,6 +171,10 @@ func DetectInterpreters(ctx context.Context) (allInterpreters, error) {
 			})
 		}
 	}
+	if runtime.GOOS == "windows" && len(found) == 0 {
+		return nil, fmt.Errorf("%w. Install them from %s or %s and restart the shell",
+			ErrNoPythonInterpreters, officialMswinPython, microsoftStorePython)
+	}
 	if len(found) == 0 {
 		return nil, ErrNoPythonInterpreters
 	}

libs/python/interpreters_test.go renamed to libs/python/interpreters_unix_test.go

@@ -1,3 +1,5 @@
+//go:build unix
+
 package python
 
 import (

libs/python/interpreters_win_test.go

@@ -0,0 +1,27 @@
+//go:build windows
+
+package python
+
+import (
+	"context"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestAtLeastOnePythonInstalled(t *testing.T) {
+	ctx := context.Background()
+	all, err := DetectInterpreters(ctx)
+	assert.NoError(t, err)
+	a := all.Latest()
+	t.Logf("latest is: %s", a)
+	assert.True(t, len(all) > 0)
+}
+
+func TestNoInterpretersFound(t *testing.T) {
+	t.Setenv("PATH", t.TempDir())
+
+	ctx := context.Background()
+	_, err := DetectInterpreters(ctx)
+	assert.ErrorIs(t, err, ErrNoPythonInterpreters)
+}

libs/python/venv_test.go

@@ -1,6 +1,7 @@
 package python
 
 import (
+	"runtime"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -24,5 +25,9 @@ func TestDetectVirtualEnvPath_wrongDir(t *testing.T) {
 func TestDetectVirtualEnvPath_happy(t *testing.T) {
 	venv, err := DetectVirtualEnvPath("testdata/some-dir-with-venv")
 	assert.NoError(t, err)
-	assert.Equal(t, "testdata/some-dir-with-venv/.venv", venv)
+	found := "testdata/some-dir-with-venv/.venv"
+	if runtime.GOOS == "windows" {
+		found = "testdata\\some-dir-with-venv\\.venv"
+	}
+	assert.Equal(t, found, venv)
 }