Skip to content

Commit b580590

Browse files
authored
internal: simplify error handling, always propagate reference parsing error (#3992)
1 parent b97d90c commit b580590

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

bundle/direct/bundle_plan.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -372,11 +372,8 @@ func (b *DeploymentBundle) resolveReferences(ctx context.Context, entry *deployp
372372
for fieldPathStr, refString := range entry.NewState.Refs {
373373
refs, ok := dynvar.NewRef(dyn.V(refString))
374374
if !ok {
375-
if !isLocal {
376-
logdiag.LogError(ctx, fmt.Errorf("%s: cannot parse %q", errorPrefix, refString))
377-
return false
378-
}
379-
continue
375+
logdiag.LogError(ctx, fmt.Errorf("%s: cannot parse %q", errorPrefix, refString))
376+
return false
380377
}
381378

382379
for _, pathString := range refs.References() {

0 commit comments

Comments
 (0)