Fix testutil.RandomName to use the full character set (#2020)

denik · web-flow · commit b6f299974ffd · 2024-12-16T17:21:20.000+01:00
## Changes
It was using first 12 chars, that does not seem intended.

## Tests
Existing tests.
diff --git a/internal/testutil/helpers.go b/internal/testutil/helpers.go
@@ -23,7 +23,7 @@ func RandomName(prefix ...string) string {
 	randLen := 12
 	b := make([]byte, randLen)
 	for i := range b {
-		b[i] = charset[rand.Intn(randLen)]
+		b[i] = charset[rand.Intn(len(charset))]
 	}
 	if len(prefix) > 0 {
 		return fmt.Sprintf("%s%s", strings.Join(prefix, ""), b)

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ func RandomName(prefix ...string) string {`
`23`	`23`	`randLen := 12`
`24`	`24`	`b := make([]byte, randLen)`
`25`	`25`	`for i := range b {`
`26`		`- b[i] = charset[rand.Intn(randLen)]`
	`26`	`+ b[i] = charset[rand.Intn(len(charset))]`
`27`	`27`	`}`
`28`	`28`	`if len(prefix) > 0 {`
`29`	`29`	`return fmt.Sprintf("%s%s", strings.Join(prefix, ""), b)`