Give warning when a bundle destroy will delete data (#3346)

shreyas-goenka · web-flow · commit beb8f0198692 · 2025-08-05T18:52:21.000Z
## Why
This warning is necessary to ensure users understand the full scope of
destroying a bundle deployment.

## Tests
Updating existing integration tests provides enough coverage.
diff --git a/acceptance/bundle/deploy/pipeline/allow-duplicate-names/output.txt b/acceptance/bundle/deploy/pipeline/allow-duplicate-names/output.txt
@@ -46,6 +46,10 @@ Deployment complete!
 The following resources will be deleted:
   delete pipeline pipeline_one
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline pipeline_one
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/acc-bundle-deploy-pipeline-duplicate-names-[UNIQUE_NAME]/default
 
 Deleting files...
diff --git a/acceptance/bundle/deploy/pipeline/auto-approve/output.txt b/acceptance/bundle/deploy/pipeline/auto-approve/output.txt
@@ -58,6 +58,10 @@ The following resources will be deleted:
   delete job foo
   delete pipeline bar
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline bar
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/[UNIQUE_NAME]
 
 Deleting files...
diff --git a/acceptance/bundle/deploy/pipeline/recreate/output.txt b/acceptance/bundle/deploy/pipeline/recreate/output.txt
@@ -37,7 +37,8 @@ recreate schemas.bar
 === Try to redeploy the bundle, pointing the DLT pipeline to a different UC catalog
 >>> errcode [CLI] bundle deploy --force-lock --var=catalog=another_catalog
 Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/[UNIQUE_NAME]/files...
-The following UC schemas will be deleted or recreated. Any underlying data may be lost:
+
+This action will result in the deletion or recreation of the following UC schemas. Any underlying data may be lost:
   recreate schema bar
 
 This action will result in the deletion or recreation of the following DLT Pipelines along with the
@@ -55,6 +56,13 @@ The following resources will be deleted:
   delete pipeline foo
   delete schema bar
 
+This action will result in the deletion of the following UC schemas. Any underlying data may be lost:
+  delete schema bar
+
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline foo
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/[UNIQUE_NAME]
 
 Deleting files...
diff --git a/acceptance/bundle/deploy/schema/auto-approve/output.txt b/acceptance/bundle/deploy/schema/auto-approve/output.txt
@@ -54,7 +54,8 @@ test-file-[UNIQUE_NAME].txt -> dbfs:/Volumes/main/test-schema-[UNIQUE_NAME]/test
 === Try to redeploy the bundle - should fail without --auto-approve
 >>> [CLI] bundle deploy
 Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/[UNIQUE_NAME]/files...
-The following UC schemas will be deleted or recreated. Any underlying data may be lost:
+
+This action will result in the deletion or recreation of the following UC schemas. Any underlying data may be lost:
   delete schema bar
 
 This action will result in the deletion or recreation of the following DLT Pipelines along with the
@@ -71,6 +72,13 @@ The following resources will be deleted:
   delete pipeline foo
   delete schema bar
 
+This action will result in the deletion of the following UC schemas. Any underlying data may be lost:
+  delete schema bar
+
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline foo
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/[UNIQUE_NAME]
 
 Deleting files...
diff --git a/acceptance/bundle/deploy/volume/recreate/output.txt b/acceptance/bundle/deploy/volume/recreate/output.txt
@@ -69,6 +69,16 @@ The following resources will be deleted:
   delete schema schema2
   delete volume foo
 
+This action will result in the deletion of the following UC schemas. Any underlying data may be lost:
+  delete schema schema1
+  delete schema schema2
+
+This action will result in the deletion of the following volumes.
+For managed volumes, the files stored in the volume are also deleted from your
+cloud tenant within 30 days. For external volumes, the metadata about the volume
+is removed from the catalog, but the underlying files are not deleted:
+  delete volume foo
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-uc-volumes-[UNIQUE_NAME]/default
 
 Deleting files...
diff --git a/acceptance/bundle/destroy/all-resources/output.txt b/acceptance/bundle/destroy/all-resources/output.txt
@@ -10,6 +10,13 @@ The following resources will be deleted:
   delete pipeline my_pipeline
   delete schema my_schema
 
+This action will result in the deletion of the following UC schemas. Any underlying data may be lost:
+  delete schema my_schema
+
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline my_pipeline
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default
 
 Deleting files...
diff --git a/acceptance/bundle/destroy/jobs-and-pipeline/output.txt b/acceptance/bundle/destroy/jobs-and-pipeline/output.txt
@@ -52,6 +52,10 @@ The following resources will be deleted:
   delete job foo
   delete pipeline bar
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline bar
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/[UNIQUE_NAME]
 
 Deleting files...
diff --git a/acceptance/bundle/resources/pipelines/recreate/change-catalog/output.txt b/acceptance/bundle/resources/pipelines/recreate/change-catalog/output.txt
@@ -130,6 +130,10 @@ Exit code (musterr): 1
 The following resources will be deleted:
   delete pipeline my
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline my
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/acc-[UNIQUE_NAME]/default
 
 Deleting files...
diff --git a/acceptance/bundle/resources/pipelines/recreate/change-ingestion-definition/output.txt b/acceptance/bundle/resources/pipelines/recreate/change-ingestion-definition/output.txt
@@ -146,6 +146,10 @@ Exit code (musterr): 1
 The following resources will be deleted:
   delete pipeline my
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline my
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/acc-[UNIQUE_NAME]/default
 
 Deleting files...
diff --git a/acceptance/bundle/resources/pipelines/recreate/change-storage/output.txt b/acceptance/bundle/resources/pipelines/recreate/change-storage/output.txt
@@ -130,6 +130,10 @@ Exit code (musterr): 1
 The following resources will be deleted:
   delete pipeline my
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline my
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/acc-[UNIQUE_NAME]/default
 
 Deleting files...
diff --git a/acceptance/bundle/resources/pipelines/update/output.txt b/acceptance/bundle/resources/pipelines/update/output.txt
@@ -70,6 +70,10 @@ Deployment complete!
 The following resources will be deleted:
   delete pipeline my
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline my
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/acc-[UNIQUE_NAME]/default
 
 Deleting files...
diff --git a/acceptance/bundle/resources/schemas/recreate/output.txt b/acceptance/bundle/resources/schemas/recreate/output.txt
@@ -35,7 +35,8 @@ recreate schemas.schema1
 
 >>> [CLI] bundle deploy --auto-approve
 Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
-The following UC schemas will be deleted or recreated. Any underlying data may be lost:
+
+This action will result in the deletion or recreation of the following UC schemas. Any underlying data may be lost:
   recreate schema schema1
 Deploying resources...
 Updating deployment state...
diff --git a/acceptance/bundle/resources/volumes/change-comment/output.txt b/acceptance/bundle/resources/volumes/change-comment/output.txt
@@ -87,6 +87,12 @@ Deployment complete!
 The following resources will be deleted:
   delete volume volume1
 
+This action will result in the deletion of the following volumes.
+For managed volumes, the files stored in the volume are also deleted from your
+cloud tenant within 30 days. For external volumes, the metadata about the volume
+is removed from the catalog, but the underlying files are not deleted:
+  delete volume volume1
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default
 
 Deleting files...
diff --git a/acceptance/bundle/summary/modified_status/output.txt b/acceptance/bundle/summary/modified_status/output.txt
@@ -132,6 +132,13 @@ The following resources will be deleted:
   delete schema my_schema
   delete sql_warehouse my_sql_warehouse
 
+This action will result in the deletion of the following UC schemas. Any underlying data may be lost:
+  delete schema my_schema
+
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline my_pipeline
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default
 
 Deleting files...
diff --git a/acceptance/bundle/templates/default-python/integration_classic/output.txt b/acceptance/bundle/templates/default-python/integration_classic/output.txt
@@ -88,6 +88,10 @@ The following resources will be deleted:
   delete job project_name_[UNIQUE_NAME]_job
   delete pipeline project_name_[UNIQUE_NAME]_pipeline
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline project_name_[UNIQUE_NAME]_pipeline
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/project_name_[UNIQUE_NAME]/dev
 
 Deleting files...
@@ -400,6 +404,10 @@ The following resources will be deleted:
   delete job project_name_[UNIQUE_NAME]_job
   delete pipeline project_name_[UNIQUE_NAME]_pipeline
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline project_name_[UNIQUE_NAME]_pipeline
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/project_name_[UNIQUE_NAME]/prod
 
 Deleting files...
diff --git a/acceptance/pipelines/destroy/auto-approve/output.txt b/acceptance/pipelines/destroy/auto-approve/output.txt
@@ -16,6 +16,10 @@ Exit code: 1
 The following resources will be deleted:
   delete pipeline my_pipeline
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline my_pipeline
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-pipeline-destroy/default
 
 Deleting files...
diff --git a/acceptance/pipelines/destroy/destroy-pipeline/output.txt b/acceptance/pipelines/destroy/destroy-pipeline/output.txt
@@ -11,6 +11,10 @@ View your pipeline my_pipeline here: [DATABRICKS_URL]/pipelines/[UUID]?o=[NUMID]
 The following resources will be deleted:
   delete pipeline my_pipeline
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline my_pipeline
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-pipeline-destroy/default
 
 Deleting files...
diff --git a/acceptance/pipelines/destroy/force-lock/output.txt b/acceptance/pipelines/destroy/force-lock/output.txt
@@ -22,6 +22,10 @@ Exit code: 1
 The following resources will be deleted:
   delete pipeline foo
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline foo
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-pipeline-force-lock/default
 
 Deleting files...
diff --git a/acceptance/pipelines/e2e/output.txt b/acceptance/pipelines/e2e/output.txt
@@ -76,6 +76,11 @@ The following resources will be deleted:
   delete pipeline my_project_pipeline
   delete pipeline my_project_pipeline_2
 
+This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:
+  delete pipeline my_project_pipeline
+  delete pipeline my_project_pipeline_2
+
 All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/my_project/dev
 
 Deleting files...
diff --git a/bundle/phases/deploy.go b/bundle/phases/deploy.go
@@ -64,44 +64,31 @@ func approvalForDeploy(ctx context.Context, b *bundle.Bundle) (bool, error) {
 
 	// One or more UC schema resources will be deleted or recreated.
 	if len(schemaActions) != 0 {
-		cmdio.LogString(ctx, "The following UC schemas will be deleted or recreated. Any underlying data may be lost:")
+		cmdio.LogString(ctx, deleteOrRecreateSchemaMessage)
 		for _, action := range schemaActions {
 			cmdio.Log(ctx, action)
 		}
 	}
 
 	// One or more DLT pipelines is being recreated.
 	if len(dltActions) != 0 {
-		msg := `
-This action will result in the deletion or recreation of the following DLT Pipelines along with the
-Streaming Tables (STs) and Materialized Views (MVs) managed by them. Recreating the Pipelines will
-restore the defined STs and MVs through full refresh. Note that recreation is necessary when pipeline
-properties such as the 'catalog' or 'storage' are changed:`
-		cmdio.LogString(ctx, msg)
+		cmdio.LogString(ctx, deleteOrRecreateDltMessage)
 		for _, action := range dltActions {
 			cmdio.Log(ctx, action)
 		}
 	}
 
 	// One or more volumes is being recreated.
 	if len(volumeActions) != 0 {
-		msg := `
-This action will result in the deletion or recreation of the following volumes.
-For managed volumes, the files stored in the volume are also deleted from your
-cloud tenant within 30 days. For external volumes, the metadata about the volume
-is removed from the catalog, but the underlying files are not deleted:`
-		cmdio.LogString(ctx, msg)
+		cmdio.LogString(ctx, deleteOrRecreateVolumeMessage)
 		for _, action := range volumeActions {
 			cmdio.Log(ctx, action)
 		}
 	}
 
 	// One or more dashboards is being recreated.
 	if len(dashboardActions) != 0 {
-		msg := `
-This action will result in the deletion or recreation of the following dashboards.
-This will result in changed IDs and permanent URLs of the dashboards that will be recreated:`
-		cmdio.LogString(ctx, msg)
+		cmdio.LogString(ctx, deleteOrRecreateDashboardMessage)
 		for _, action := range dashboardActions {
 			cmdio.Log(ctx, action)
 		}
diff --git a/bundle/phases/destroy.go b/bundle/phases/destroy.go
@@ -69,6 +69,34 @@ func approvalForDestroy(ctx context.Context, b *bundle.Bundle) (bool, error) {
 
 	}
 
+	schemaActions := deployplan.FilterGroup(deleteActions, "schemas", deployplan.ActionTypeDelete)
+	dltActions := deployplan.FilterGroup(deleteActions, "pipelines", deployplan.ActionTypeDelete)
+	volumeActions := deployplan.FilterGroup(deleteActions, "volumes", deployplan.ActionTypeDelete)
+
+	if len(schemaActions) > 0 {
+		cmdio.LogString(ctx, deleteSchemaMessage)
+		for _, a := range schemaActions {
+			cmdio.Log(ctx, a)
+		}
+		cmdio.LogString(ctx, "")
+	}
+
+	if len(dltActions) > 0 {
+		cmdio.LogString(ctx, deleteDltMessage)
+		for _, a := range dltActions {
+			cmdio.Log(ctx, a)
+		}
+		cmdio.LogString(ctx, "")
+	}
+
+	if len(volumeActions) > 0 {
+		cmdio.LogString(ctx, deleteVolumeMessage)
+		for _, a := range volumeActions {
+			cmdio.Log(ctx, a)
+		}
+		cmdio.LogString(ctx, "")
+	}
+
 	cmdio.LogString(ctx, "All files and directories at the following location will be deleted: "+b.Config.Workspace.RootPath)
 	cmdio.LogString(ctx, "")
 
diff --git a/bundle/phases/messages.go b/bundle/phases/messages.go
@@ -0,0 +1,36 @@
+package phases
+
+// Messages for bundle deploy.
+const (
+	deleteOrRecreateSchemaMessage = `
+This action will result in the deletion or recreation of the following UC schemas. Any underlying data may be lost:`
+
+	deleteOrRecreateDltMessage = `
+This action will result in the deletion or recreation of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them. Recreating the Pipelines will
+restore the defined STs and MVs through full refresh. Note that recreation is necessary when pipeline
+properties such as the 'catalog' or 'storage' are changed:`
+
+	deleteOrRecreateVolumeMessage = `
+This action will result in the deletion or recreation of the following volumes.
+For managed volumes, the files stored in the volume are also deleted from your
+cloud tenant within 30 days. For external volumes, the metadata about the volume
+is removed from the catalog, but the underlying files are not deleted:`
+
+	deleteOrRecreateDashboardMessage = `
+This action will result in the deletion or recreation of the following dashboards.
+This will result in changed IDs and permanent URLs of the dashboards that will be recreated:`
+)
+
+// Messages for bundle destroy.
+const (
+	deleteSchemaMessage = `This action will result in the deletion of the following UC schemas. Any underlying data may be lost:`
+
+	deleteDltMessage = `This action will result in the deletion of the following DLT Pipelines along with the
+Streaming Tables (STs) and Materialized Views (MVs) managed by them:`
+
+	deleteVolumeMessage = `This action will result in the deletion of the following volumes.
+For managed volumes, the files stored in the volume are also deleted from your
+cloud tenant within 30 days. For external volumes, the metadata about the volume
+is removed from the catalog, but the underlying files are not deleted:`
+)
