respond to feedback + failing tests

Author: leonli33-databricks

acceptance/bundle/resources/dashboards/dataset-catalog-schema/test.toml

@@ -3,6 +3,7 @@ Cloud = true
 RequiresWarehouse = true
 RecordRequests = true
 
+# TODO: test terraform once commit had been released (https://github.com/databricks/terraform-provider-databricks/pull/5259)
 [EnvMatrix]
   DATABRICKS_BUNDLE_ENGINE = ["direct"]
 

bundle/config/resources/dashboard.go

@@ -59,10 +59,12 @@ type DashboardConfig struct {
 
 	// DatasetCatalog sets the default catalog for all datasets in this dashboard.
 	// When set, this overrides the catalog specified in individual dataset definitions.
+	// These are request only parameters and not returned by the GET API.
 	DatasetCatalog string `json:"dataset_catalog,omitempty"`
 
 	// DatasetSchema sets the default schema for all datasets in this dashboard.
 	// When set, this overrides the schema specified in individual dataset definitions.
+	// These are request only parameters and not returned by the GET API.
 	DatasetSchema string `json:"dataset_schema,omitempty"`
 }
 

bundle/direct/dresources/dashboard.go

@@ -123,6 +123,7 @@ func (r *ResourceDashboard) DoRead(ctx context.Context, id string) (*resources.D
 		WarehouseId:         dashboard.WarehouseId,
 		SerializedDashboard: dashboard.SerializedDashboard,
 		ParentPath:          ensureWorkspacePrefix(dashboard.ParentPath),
+		// diffs are detected via etags, which will change if dataset_catalog/dataset_schema is updated.
 		DatasetCatalog:      "",
 		DatasetSchema:       "",
 

bundle/internal/schema/annotations.yml

@@ -527,6 +527,13 @@ github.com/databricks/cli/bundle/config/resources.ClusterPermission:
   "user_name":
     "description": |-
       PLACEHOLDER
+github.com/databricks/cli/bundle/config/resources.Dashboard:
+  "dataset_catalog":
+    "description": |-
+      Sets the default catalog for all datasets in this dashboard. When set, this overrides the catalog specified in individual dataset definitions.
+  "dataset_schema":
+    "description": |-
+      Sets the default schema for all datasets in this dashboard. When set, this overrides the schema specified in individual dataset definitions.
 github.com/databricks/cli/bundle/config/resources.DashboardPermission:
   "group_name":
     "description": |-