Add unit tests

Author: pkosiec

cmd/workspace/apps/errors.go

@@ -6,23 +6,28 @@ import (
 	"github.com/spf13/cobra"
 )
 
+const tailLinesSuggestedValue = 100
+
 // AppDeploymentError wraps deployment errors with a helpful logs command suggestion.
 type AppDeploymentError struct {
-	Err     error
-	AppName string
-	Profile string
+	Underlying error
+	appName    string
+	profile    string
 }
 
 func (e *AppDeploymentError) Error() string {
-	suggestion := "\n\nTo view app logs, run:\n  databricks workspace apps logs " + e.AppName
-	if e.Profile != "" {
-		suggestion = fmt.Sprintf("%s --profile %s", suggestion, e.Profile)
+	suggestion := fmt.Sprintf("\n\nTo view app logs, run:\n  databricks apps logs %s --tail-lines %d",
+		e.appName,
+		tailLinesSuggestedValue,
+	)
+	if e.profile != "" {
+		suggestion = fmt.Sprintf("%s --profile %s", suggestion, e.profile)
 	}
-	return e.Err.Error() + suggestion
+	return e.Underlying.Error() + suggestion
 }
 
 func (e *AppDeploymentError) Unwrap() error {
-	return e.Err
+	return e.Underlying
 }
 
 // newAppDeploymentError creates an AppDeploymentError with profile info from the command.
@@ -33,8 +38,8 @@ func newAppDeploymentError(cmd *cobra.Command, appName string, err error) error
 		profile = profileFlag.Value.String()
 	}
 	return &AppDeploymentError{
-		Err:     err,
-		AppName: appName,
-		Profile: profile,
+		Underlying: err,
+		appName:    appName,
+		profile:    profile,
 	}
 }

cmd/workspace/apps/errors_test.go

@@ -0,0 +1,54 @@
+package apps
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestAppDeploymentError_Error_WithoutProfile(t *testing.T) {
+	originalErr := errors.New("deployment failed: timeout")
+	appErr := &AppDeploymentError{
+		Underlying: originalErr,
+		appName:    "my-app",
+		profile:    "",
+	}
+
+	result := appErr.Error()
+
+	assert.Contains(t, result, "deployment failed: timeout")
+	assert.Contains(t, result, "To view app logs, run:")
+	assert.Contains(t, result, "databricks apps logs my-app --tail-lines 100")
+	assert.NotContains(t, result, "--profile")
+}
+
+func TestAppDeploymentError_Error_WithProfile(t *testing.T) {
+	originalErr := errors.New("deployment failed: timeout")
+	appErr := &AppDeploymentError{
+		Underlying: originalErr,
+		appName:    "my-app",
+		profile:    "production",
+	}
+
+	result := appErr.Error()
+
+	assert.Contains(t, result, "deployment failed: timeout")
+	assert.Contains(t, result, "To view app logs, run:")
+	assert.Contains(t, result, "databricks apps logs my-app --tail-lines 100 --profile production")
+}
+
+func TestAppDeploymentError_Unwrap(t *testing.T) {
+	originalErr := errors.New("original error")
+	appErr := &AppDeploymentError{
+		Underlying: originalErr,
+		appName:    "my-app",
+		profile:    "",
+	}
+
+	unwrapped := appErr.Unwrap()
+
+	require.Equal(t, originalErr, unwrapped)
+	assert.ErrorIs(t, appErr, originalErr, "errors.Is should work with wrapped error")
+}

experimental/apps-mcp/lib/prompts/target_apps.tmpl

@@ -22,7 +22,7 @@ This is battle-tested to catch common issues before deployment. Prefer using thi
 
 ### View App Logs
 To troubleshoot deployed apps, view their logs:
-  invoke_databricks_cli 'workspace apps logs <app-name> --tail-lines 100'
+  invoke_databricks_cli 'apps logs <app-name> --tail-lines 100'
 
 Add --follow to stream logs continuously. Useful for debugging deployment failures or runtime issues.