direct: Add waiting for the app after create same as in TF implementation (#3484)

## Changes
Copied an implementation from TF so both behaviours are in line

https://github.com/databricks/terraform-provider-databricks/blob/9346a78bde642b3ee4e8caec80439a71fa681a9b/internal/providers/pluginfw/products/app/resource_app.go#L161

## Why
Behaviour in TF and direct should be same, currently difference causing
app related acceptance test to fail

## Tests
Existing acceptance/bundle/run/app-with-job should pass

<!-- If your PR needs to be included in the release notes for next
release,
add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->

Author: andrewnester

bundle/terranova/tnresources/app.go

@@ -2,10 +2,12 @@ package tnresources
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/databricks/cli/bundle/config/resources"
 	"github.com/databricks/cli/libs/log"
 	"github.com/databricks/databricks-sdk-go"
+	"github.com/databricks/databricks-sdk-go/retries"
 	"github.com/databricks/databricks-sdk-go/service/apps"
 )
 
@@ -36,8 +38,6 @@ func (r *ResourceApp) DoCreate(ctx context.Context) (string, error) {
 		return "", err
 	}
 
-	// TODO: Store waiter for Wait method
-
 	return waiter.Response.Name, nil
 }
 
@@ -64,11 +64,41 @@ func DeleteApp(ctx context.Context, client *databricks.WorkspaceClient, id strin
 }
 
 func (r *ResourceApp) WaitAfterCreate(ctx context.Context) error {
-	// Intentional no-op
+	_, err := r.waitForApp(ctx, r.client, r.config.Name)
+	if err != nil {
+		return err
+	}
 	return nil
 }
 
 func (r *ResourceApp) WaitAfterUpdate(ctx context.Context) error {
 	// Intentional no-op
 	return nil
 }
+
+// waitForApp waits for the app to reach the target state. The target state is either ACTIVE or STOPPED.
+// Apps with no_compute set to true will reach the STOPPED state, otherwise they will reach the ACTIVE state.
+// We can't use the default waiter from SDK because it only waits on ACTIVE state but we need also STOPPED state.
+// Ideally this should be done in Go SDK but currently only ACTIVE is marked as terminal state
+// so this would need to be addressed by Apps service team first in their proto.
+func (r *ResourceApp) waitForApp(ctx context.Context, w *databricks.WorkspaceClient, name string) (*apps.App, error) {
+	retrier := retries.New[apps.App](retries.WithTimeout(-1), retries.WithRetryFunc(shouldRetry))
+	return retrier.Run(ctx, func(ctx context.Context) (*apps.App, error) {
+		app, err := w.Apps.GetByName(ctx, name)
+		if err != nil {
+			return nil, retries.Halt(err)
+		}
+		status := app.ComputeStatus.State
+		statusMessage := app.ComputeStatus.Message
+		switch status {
+		case apps.ComputeStateActive, apps.ComputeStateStopped:
+			return app, nil
+		case apps.ComputeStateError:
+			err := fmt.Errorf("failed to reach %s or %s, got %s: %s",
+				apps.ComputeStateActive, apps.ComputeStateStopped, status, statusMessage)
+			return nil, retries.Halt(err)
+		default:
+			return nil, retries.Continues(statusMessage)
+		}
+	})
+}

bundle/terranova/tnresources/util.go

@@ -2,6 +2,8 @@ package tnresources
 
 import (
 	"reflect"
+
+	"github.com/databricks/databricks-sdk-go/retries"
 )
 
 // filterFields creates a new slice with fields present only in the provided type.
@@ -18,3 +20,16 @@ func filterFields[T any](fields []string) []string {
 
 	return result
 }
+
+// This is copied from the retries package of the databricks-sdk-go. It should be made public,
+// but for now, I'm copying it here.
+func shouldRetry(err error) bool {
+	if err == nil {
+		return false
+	}
+	e := err.(*retries.Err)
+	if e == nil {
+		return false
+	}
+	return !e.Halt
+}