Skip to content

Commit d41686f

Browse files
authored
Group test results in a single downstream job (#4078)
## Why We need a single "required check" for tests. Now that we split tests into separate jobs that may or may not be skipped, they can no longer be required checks themselves. This new downstream job that groups the result of all of them will always run and can become the new "required check".
1 parent 7af9afd commit d41686f

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

.github/workflows/push.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,23 @@ jobs:
270270
run: |
271271
make test-pipelines
272272
273+
# This job groups the result of all the above test jobs.
274+
# If any of them failed, this job will be skipped.
275+
# It is a required check, so it blocks auto-merge and the merge queue.
276+
test-result:
277+
needs:
278+
- test
279+
- test-exp-aitools
280+
- test-exp-apps-mcp
281+
- test-exp-ssh
282+
- test-pipelines
283+
284+
name: test-result
285+
runs-on: ubuntu-latest
286+
287+
steps:
288+
- run: echo "All tests passed ✅"
289+
273290
validate-generated-is-up-to-date:
274291
needs: cleanups
275292
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)