direct: Support schemas deletion and recreation (#3341)

## Changes
Implement missing delete and recreate flows for schemas.

## Tests
New acceptance test.

Author: denik

acceptance/bundle/resources/schemas/recreate/databricks.yml

@@ -0,0 +1,8 @@
+resources:
+  schemas:
+    schema1:
+      name: myschema
+      catalog_name: main
+      comment: COMMENT1
+      # Note, uncommenting causes different requests sent between TF and direct
+      #storage_root: ""

…e/bundle/resources/schemas/out.test.toml …resources/schemas/recreate/out.test.tomlacceptance/bundle/resources/schemas/out.test.toml renamed to acceptance/bundle/resources/schemas/recreate/out.test.toml acceptance/bundle/resources/schemas/out.test.toml renamed to acceptance/bundle/resources/schemas/recreate/out.test.toml

@@ -0,0 +1,70 @@
+
+>>> [CLI] bundle deploy
+Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
+Deploying resources...
+Updating deployment state...
+Deployment complete!
+
+>>> print_requests
+{
+  "method": "POST",
+  "path": "/api/2.1/unity-catalog/schemas",
+  "body": {
+    "catalog_name": "main",
+    "comment": "COMMENT1",
+    "name": "myschema"
+  }
+}
+
+>>> [CLI] bundle summary -o json
+{
+  "schema1": {
+    "catalog_name": "main",
+    "comment": "COMMENT1",
+    "id": "main.myschema",
+    "name": "myschema",
+    "url": "[DATABRICKS_URL]/explore/data/main/myschema?o=[NUMID]"
+  }
+}
+
+=== Update catalog_name and re-deploy
+>>> update_file.py databricks.yml catalog_name: main catalog_name: newmain
+
+>>> [CLI] bundle plan
+recreate schemas.schema1
+
+>>> [CLI] bundle deploy --auto-approve
+Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
+The following UC schemas will be deleted or recreated. Any underlying data may be lost:
+  recreate schema schema1
+Deploying resources...
+Updating deployment state...
+Deployment complete!
+
+>>> print_requests
+{
+  "method": "DELETE",
+  "path": "/api/2.1/unity-catalog/schemas/main.myschema"
+}
+{
+  "method": "POST",
+  "path": "/api/2.1/unity-catalog/schemas",
+  "body": {
+    "catalog_name": "newmain",
+    "comment": "COMMENT1",
+    "name": "myschema"
+  }
+}
+
+>>> musterr [CLI] schemas get main.myschema
+Error: Resource catalog.SchemaInfo not found: main.myschema
+
+Exit code (musterr): 1
+
+>>> [CLI] schemas get newmain.myschema
+{
+  "catalog_name":"newmain",
+  "comment":"COMMENT1",
+  "full_name":"newmain.myschema",
+  "name":"myschema"
+}

acceptance/bundle/resources/schemas/recreate/output.txt

@@ -0,0 +1,20 @@
+echo "*" > .gitignore
+trace $CLI bundle deploy
+
+print_requests() {
+    jq 'select(.method != "GET" and (.path | contains("/unity")))' < out.requests.txt
+    rm out.requests.txt
+}
+
+trace print_requests
+trace $CLI bundle summary -o json | jq .resources.schemas
+
+title "Update catalog_name and re-deploy"
+trace update_file.py databricks.yml "catalog_name: main" "catalog_name: newmain"
+trace $CLI bundle plan
+trace $CLI bundle deploy --auto-approve
+trace print_requests
+
+trace musterr $CLI schemas get main.myschema
+trace $CLI schemas get newmain.myschema
+rm out.requests.txt

acceptance/bundle/resources/schemas/recreate/script

@@ -0,0 +1,5 @@
+Local = true
+Cloud = false
+
+[EnvMatrix]
+  DATABRICKS_CLI_DEPLOYMENT = ["terraform", "direct-exp"]

…/bundle/resources/schemas/databricks.yml …/resources/schemas/update/databricks.ymlacceptance/bundle/resources/schemas/databricks.yml renamed to acceptance/bundle/resources/schemas/update/databricks.yml acceptance/bundle/resources/schemas/databricks.yml renamed to acceptance/bundle/resources/schemas/update/databricks.yml

@@ -80,7 +80,12 @@ var SupportedResources = map[string]ResourceSettings{
 		New:        reflect.ValueOf(NewResourceSchema),
 		ConfigType: reflect.TypeOf(ResourceSchema{}.config),
 		DeleteFN:   DeleteSchema,
-		// RecreateFields: TODO
+		// TF: https://github.com/databricks/terraform-provider-databricks/blob/03a2515/catalog/resource_schema.go#L14
+		RecreateFields: mkMap(
+			".name",
+			".catalog_name",
+			".storage_root",
+		),
 	},
 	"volumes": {
 		New:        reflect.ValueOf(NewResourceVolume),

acceptance/bundle/resources/schemas/update/out.test.toml

@@ -52,7 +52,10 @@ func (r *ResourceSchema) DoUpdate(ctx context.Context, id string) (string, error
 }
 
 func DeleteSchema(ctx context.Context, client *databricks.WorkspaceClient, id string) error {
-	// TODO: implement schema deletion
+	err := client.Schemas.Delete(ctx, catalog.DeleteSchemaRequest{FullName: id, Force: true})
+	if err != nil {
+		return SDKError{Method: "Schemas.Delete", Err: err}
+	}
 	return nil
 }