Fix lakeview publish to explicitly send embed_credentials as false by default (#4066)

Fixes: #4001

## Changes

Add override for `lakeview publish` to explicitly send
`embed_credentials: false` when `--embed-credentials` flag is not
provided.

## Why

The SDK omits `false` boolean values from JSON requests due to
`omitempty`. This caused the API to default to `true`, embedding
credentials even when the flag wasn't set. The fix uses
`ForceSendFields` to always send the value explicitly.

## Tests

Added acceptance test verifying the request body contains
`"embed_credentials": false`.

---------

Co-authored-by: Denis Bilenko <[email protected]>

Author: varundeepsaini

NEXT_CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Notable Changes
 
 ### CLI
+* Fix lakeview publish to default `embed_credentials` to false ([#4066](https://github.com/databricks/cli/pull/4066))
 
 ### Bundles
 * Add support for configurable catalog/schema for dashboards ([#4130](https://github.com/databricks/cli/pull/4130))

acceptance/workspace/lakeview/publish/out.requests.txt

@@ -0,0 +1,23 @@
+{
+  "method": "POST",
+  "path": "/api/2.0/workspace/mkdirs",
+  "body": {
+    "path": "/Users/[USERNAME]"
+  }
+}
+{
+  "method": "POST",
+  "path": "/api/2.0/lakeview/dashboards",
+  "body": {
+    "display_name": "Test Dashboard",
+    "parent_path": "/Users/[USERNAME]",
+    "warehouse_id": "test-warehouse"
+  }
+}
+{
+  "method": "POST",
+  "path": "/api/2.0/lakeview/dashboards/[DASHBOARD_ID]/published",
+  "body": {
+    "embed_credentials": false
+  }
+}

acceptance/workspace/lakeview/publish/out.test.toml

@@ -0,0 +1,11 @@
+
+>>> [CLI] workspace mkdirs /Users/[USERNAME]
+
+>>> [CLI] lakeview create --json {"display_name": "Test Dashboard", "parent_path": "/Users/[USERNAME]", "warehouse_id": "test-warehouse"} -o json
+
+>>> [CLI] lakeview publish [DASHBOARD_ID]
+{
+  "display_name":"Test Dashboard",
+  "embed_credentials":false,
+  "warehouse_id":"test-warehouse"
+}

acceptance/workspace/lakeview/publish/output.txt

@@ -0,0 +1,7 @@
+trace $CLI workspace mkdirs /Users/[email protected]
+
+trace $CLI lakeview create --json '{"display_name": "Test Dashboard", "parent_path": "/Users/[email protected]", "warehouse_id": "test-warehouse"}' -o json > tmp.json
+dashboard_id=$(jq -r .dashboard_id < tmp.json)
+rm tmp.json
+echo "$dashboard_id:DASHBOARD_ID" >> ACC_REPLS
+trace $CLI lakeview publish $dashboard_id

acceptance/workspace/lakeview/publish/script

@@ -0,0 +1,4 @@
+RecordRequests = true
+
+[Env]
+MSYS_NO_PATHCONV = "1"

acceptance/workspace/lakeview/publish/test.toml

@@ -0,0 +1,19 @@
+package lakeview
+
+import (
+	"github.com/databricks/databricks-sdk-go/service/dashboards"
+	"github.com/spf13/cobra"
+)
+
+func publishOverride(cmd *cobra.Command, req *dashboards.PublishRequest) {
+	originalRunE := cmd.RunE
+	cmd.RunE = func(cmd *cobra.Command, args []string) error {
+		// Force send embed_credentials even when false, otherwise the API defaults to true.
+		req.ForceSendFields = append(req.ForceSendFields, "EmbedCredentials")
+		return originalRunE(cmd, args)
+	}
+}
+
+func init() {
+	publishOverrides = append(publishOverrides, publishOverride)
+}