Commit f171f8f
authored
Remove empty permissions from json output (#3715)
## Changes
When processing permissions, do not convert nils to empty slice in dyn
value.
## Why
Without this '"permissions: []"' always shows up in JSON output. When
permissions are not present in the config, this is confusing.
In addition, Permissions fields are marked as "omitempty" so even if
they are present, they should be cleaned up.
Related:
#2756 (review)
## Tests
Existing tests.1 parent acead37 commit f171f8f
File tree
49 files changed
+67
-173
lines changed- acceptance/bundle
- bundle_tag
- id
- url_ref
- url
- deploy
- dashboard/detect-change
- sql_warehouse
- includes/yml_outside_root
- override
- job_cluster_var
- job_cluster
- job_tasks
- pipeline_cluster
- paths
- git_source_jobs
- invalid_pipeline_globs
- outside_root_no_sync
- pipeline_expected_file_got_notebook
- pipeline_globs
- relative_path_outside_root
- python
- mutator-ordering
- pipelines-support
- resolve-variable
- resource-loading
- unicode-support
- resource_deps
- missing_map_key_tffix
- missing_map_key
- missing_string_field
- resources_var_presets_implicit_deps
- resources_var_presets
- resources_var
- run_as
- allowed
- regular_user
- service_principal
- pipelines_legacy
- summary/modified_status
- templates
- default-python/integration_classic
- experimental-jobs-as-code
- validate
- dashboard_defaults
- empty_resources
- empty_dict
- with_grants
- with_permissions
- job-references
- presets_max_concurrent_runs
- presets_name_prefix
- variables
- complex_multiple_files
- complex
- prepend-workspace-var
- resolve-nonstrings
- resolve-resources-fields
- variable_overrides_in_target
- bundle/config/mutator/resourcemutator
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
49 files changed
+67
-173
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
| |||
35 | 34 | | |
36 | 35 | | |
37 | 36 | | |
38 | | - | |
39 | 37 | | |
40 | 38 | | |
41 | 39 | | |
| |||
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
37 | | - | |
38 | 36 | | |
39 | 37 | | |
40 | 38 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
| |||
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
51 | | - | |
52 | 50 | | |
53 | 51 | | |
54 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
| |||
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
60 | | - | |
61 | 59 | | |
62 | 60 | | |
63 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
37 | 36 | | |
38 | 37 | | |
39 | 38 | | |
40 | | - | |
41 | 39 | | |
42 | 40 | | |
43 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
| 21 | + | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| |||
42 | 41 | | |
43 | 42 | | |
44 | 43 | | |
45 | | - | |
46 | | - | |
| 44 | + | |
47 | 45 | | |
48 | 46 | | |
0 commit comments