[wip] add support for registered_models for direct deployment

Author: shreyas-goenka

acceptance/bundle/deploy/registered_models/basic/databricks.yml.tmpl

@@ -0,0 +1,11 @@
+bundle:
+  name: deploy-registered-models-basic-$UNIQUE_NAME
+
+resources:
+  registered_models:
+    my_registered_model:
+      name: $NAME
+      comment: $COMMENT
+      catalog_name: $CATALOG_NAME
+      schema_name: $SCHEMA_NAME
+      storage_location: $STORAGE_LOCATION

acceptance/bundle/deploy/registered_models/basic/out.test.toml

@@ -0,0 +1,31 @@
+
+=== create the registered model
+>>> export NAME=my-registered-model-[UNIQUE_NAME]
+
+>>> export COMMENT=original comment
+
+>>> export CATALOG_NAME=main
+
+>>> export SCHEMA_NAME=default
+
+>>> export STORAGE_LOCATION=s3://my-bucket/my-path
+
+>>> [CLI] bundle plan
+create registered_models.my_registered_model
+
+Plan: 1 to add, 0 to change, 0 to delete, 0 unchanged
+
+>>> [CLI] bundle deploy
+Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/deploy-registered-models-basic-[UNIQUE_NAME]/default/files...
+Deploying resources...
+Updating deployment state...
+Deployment complete!
+
+>>> [CLI] registered-models get main.default.my-registered-model-[UNIQUE_NAME]
+{
+  "name": "my-registered-model-[UNIQUE_NAME]",
+  "comment": "original comment",
+  "catalog_name": "main",
+  "schema_name": "default",
+  "storage_location": "abfss://decotestprod-unity-iso@decotestprodunityiso.dfs.core.windows.net/[UUID]/models/[UUID]"
+}

acceptance/bundle/deploy/registered_models/basic/output.txt

@@ -0,0 +1,12 @@
+title "create the registered model"
+
+trace export NAME="my-registered-model-$UNIQUE_NAME"
+trace export COMMENT="original comment"
+trace export CATALOG_NAME="main"
+trace export SCHEMA_NAME="default"
+trace export STORAGE_LOCATION="s3://my-bucket/my-path"
+envsubst < databricks.yml.tmpl > databricks.yml
+trace $CLI bundle plan
+trace $CLI bundle deploy
+registered_model_id=$($CLI bundle summary --output json | jq -r '.resources.registered_models.my_registered_model.id')
+trace $CLI registered-models get "${registered_model_id}" | jq '{name, comment, catalog_name, schema_name, storage_location}'

acceptance/bundle/deploy/registered_models/basic/script

@@ -0,0 +1,2 @@
+Cloud = true
+Local = false

acceptance/bundle/deploy/registered_models/basic/test.toml

@@ -17,6 +17,7 @@ var SupportedResources = map[string]any{
 	"database_catalogs":      (*ResourceDatabaseCatalog)(nil),
 	"synced_database_tables": (*ResourceSyncedDatabaseTable)(nil),
 	"alerts":                 (*ResourceAlert)(nil),
+	"registered_models":      (*ResourceRegisteredModel)(nil),
 }
 
 func InitAll(client *databricks.WorkspaceClient) (map[string]*Adapter, error) {

bundle/direct/dresources/all.go

@@ -0,0 +1,89 @@
+package dresources
+
+import (
+	"context"
+
+	"github.com/databricks/cli/bundle/config/resources"
+	"github.com/databricks/cli/bundle/deployplan"
+	"github.com/databricks/databricks-sdk-go"
+	"github.com/databricks/databricks-sdk-go/service/catalog"
+)
+
+type ResourceRegisteredModel struct {
+	client *databricks.WorkspaceClient
+}
+
+func (*ResourceRegisteredModel) New(client *databricks.WorkspaceClient) *ResourceRegisteredModel {
+	return &ResourceRegisteredModel{
+		client: client,
+	}
+}
+
+func (*ResourceRegisteredModel) PrepareState(input *resources.RegisteredModel) *catalog.CreateRegisteredModelRequest {
+	return &input.CreateRegisteredModelRequest
+}
+
+func (*ResourceRegisteredModel) RemapState(model *catalog.RegisteredModelInfo) *catalog.CreateRegisteredModelRequest {
+	return &catalog.CreateRegisteredModelRequest{
+		CatalogName:     model.CatalogName,
+		Comment:         model.Comment,
+		Name:            model.Name,
+		SchemaName:      model.SchemaName,
+		StorageLocation: model.StorageLocation,
+		ForceSendFields: filterFields[catalog.CreateRegisteredModelRequest](model.ForceSendFields),
+	}
+}
+
+func (r *ResourceRegisteredModel) DoRefresh(ctx context.Context, id string) (*catalog.RegisteredModelInfo, error) {
+	return r.client.RegisteredModels.Get(ctx, catalog.GetRegisteredModelRequest{
+		FullName: id,
+	})
+}
+
+func (r *ResourceRegisteredModel) DoCreate(ctx context.Context, config *catalog.CreateRegisteredModelRequest) (string, *catalog.RegisteredModelInfo, error) {
+	response, err := r.client.RegisteredModels.Create(ctx, *config)
+	if err != nil {
+		return "", nil, err
+	}
+
+	return response.FullName, response, nil
+}
+
+func (r *ResourceRegisteredModel) DoUpdate(ctx context.Context, id string, config *catalog.CreateRegisteredModelRequest) (*catalog.RegisteredModelInfo, error) {
+	updateRequest := catalog.UpdateRegisteredModelRequest{
+		FullName:        id,
+		Comment:         config.Comment,
+		ForceSendFields: filterFields[catalog.UpdateRegisteredModelRequest](config.ForceSendFields, "Owner", "NewName"),
+
+		// Owner is not part of the configuration tree
+		Owner: "",
+
+		// name updates are not supported yet. Can be added as a follow-up.
+		NewName: "",
+	}
+
+	response, err := r.client.RegisteredModels.Update(ctx, updateRequest)
+	if err != nil {
+		return nil, err
+	}
+
+	return response, nil
+}
+
+func (r *ResourceRegisteredModel) DoDelete(ctx context.Context, id string) error {
+	return r.client.RegisteredModels.Delete(ctx, catalog.DeleteRegisteredModelRequest{
+		FullName: id,
+	})
+}
+
+func (*ResourceRegisteredModel) FieldTriggers() map[string]deployplan.ActionType {
+	return map[string]deployplan.ActionType{
+		// The name can technically be updated without recreated. We recreate for now `though
+		// to match TF implementation.
+		"name": deployplan.ActionTypeRecreate,
+
+		"catalog_name":     deployplan.ActionTypeRecreate,
+		"schema_name":      deployplan.ActionTypeRecreate,
+		"storage_location": deployplan.ActionTypeRecreate,
+	}
+}