Add timeout and retry params to ChatDatabricks #165
Merged
+176
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sid Murching <[email protected]>
… release Signed-off-by: Sid Murching <[email protected]>
smurching
changed the title
Signed-off-by: Sid Murching <[email protected]>
smurching
commented
Aug 12, 2025
| "unitycatalog-langchain[databricks]>=0.2.0", | ||
| "databricks-connect>=16.1.1,<16.4", | ||
| "openai>=1.97.1", | ||
| "databricks-sdk>=0.63.0", |
Collaborator
Author
There was a problem hiding this comment.
TODO: update this after SDK releases
bbqiu
reviewed
Aug 12, 2025
| "pytest", | ||
| "typing_extensions", | ||
| "databricks-sdk>=0.34.0", | ||
| "databricks-sdk>=0.63.0", |
Collaborator
There was a problem hiding this comment.
if we add it to the normal list of dependencies, i think we can delete it from the dev reqs
bbqiu
approved these changes
Aug 12, 2025
Collaborator
bbqiu
left a comment
bbqiu
left a comment
There was a problem hiding this comment.
lgtm, but can't merge yet without the db-sdk release
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add standard langchain timeout and retry params to ChatDatabricks. Depends on a Databricks SDK release containing the changes in databricks/databricks-sdk-py#1025