-
Notifications
You must be signed in to change notification settings - Fork 38
Sphinx Fixes for Docs #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "psycopg", # Required by databricks_ai_bridge.lakebase | ||
| "psycopg_pool", # Required by databricks_ai_bridge.lakebase | ||
| "langgraph.checkpoint.postgres", # Required by databricks_langchain.checkpoint | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still have to do this if these dependencies/packages are lazily imported? We updated to do so as part of the this fix, so not sure if it automatically has to be imported here?
#224
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing that we still need to. We are still going to build docs for classes that uses lakebase and `psycopg.
fanzeyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| "psycopg", # Required by databricks_ai_bridge.lakebase | ||
| "psycopg_pool", # Required by databricks_ai_bridge.lakebase | ||
| "langgraph.checkpoint.postgres", # Required by databricks_langchain.checkpoint | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing that we still need to. We are still going to build docs for classes that uses lakebase and `psycopg.
mock packages in sphinx so that we can compile docs