chore: move optional dependencies to dependency groups #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP 735 defines dependency groups which is a bit different from optional dependencies -- notablely this dependency information is not exported as part of the package metadata. For dependencies needed for testing purposes, we can use dependency groups and having optional dependencies to focus on providing customizations for the users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 735 defines dependency groups, which is different from optional dependencies -- notably the dependency information is not exported to the published package metadata.
For dependencies we need for testing purposes, we can use dependency groups and only use optional features when we want to allow users to customize their dependencies based on their needs.
Test Plan
GitHub Action