Skip to content

Commit 375af9d

Browse files
authored
Fix bug that disallowed JSON flags in unity-catalog recipients update command (#549)
* . * tests * FixMinor
1 parent 84b9456 commit 375af9d

File tree

2 files changed

+620
-5
lines changed

2 files changed

+620
-5
lines changed

databricks_cli/unity_catalog/delta_sharing_cli.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ def update_recipient_cli(api_client, name, new_name, comment, owner,
272272
The public specification for the JSON request is in development.
273273
"""
274274
if ((new_name is not None) or (comment is not None) or (owner is not None) or
275-
(allowed_ip_address is not None)):
275+
len(allowed_ip_address) > 0):
276276
if (json_file is not None) or (json is not None):
277277
raise ValueError('Cannot specify JSON if any other update flags are specified')
278278
data = {'name': new_name, 'comment': comment, 'owner': owner}
@@ -291,6 +291,7 @@ def update_recipient_cli(api_client, name, new_name, comment, owner,
291291
short_help='Rotate token for the recipient.')
292292
@click.option('--name', required=True, help='Name of new recipient.')
293293
@click.option('--existing-token-expire-in-seconds', default=None, required=False,
294+
type=int,
294295
help='Expire the existing token in number of seconds from now,' +
295296
' 0 to expire it immediately.')
296297
@debug_option
@@ -359,10 +360,6 @@ def create_provider_cli(api_client, name, comment, recipient_profile_json_file,
359360
360361
The public specification for the JSON request is in development.
361362
"""
362-
if recipient_profile_json is None and recipient_profile_json_file is None:
363-
created_provider = UnityCatalogApi(api_client).create_provider(
364-
name, comment, recipient_profile=None)
365-
click.echo(mc_pretty_format(created_provider))
366363
json_cli_base(recipient_profile_json_file, recipient_profile_json,
367364
lambda json: UnityCatalogApi(api_client).create_provider(name, comment, json),
368365
error_msg='Either --recipient-profile-json-file or ' +

0 commit comments

Comments
 (0)