Skip to content

Commit 0112ca9

Browse files
Sanitize logs in com.databricks.client.jdbc.DataSource (#375)
- Removes password from logs in com.databricks.client.jdbc.DataSource - Fixes the JDBC artifact ID in repo README
1 parent 0241ebc commit 0112ca9

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ You can install Databricks JDBC driver by adding the following to your `pom.xml`
1111
```pom.xml
1212
<dependency>
1313
<groupId>com.databricks</groupId>
14-
<artifactId>databricks-jdbc-oss</artifactId>
14+
<artifactId>databricks-jdbc</artifactId>
1515
<version>0.9.0-oss</version>
1616
</dependency>
1717
```

src/main/java/com/databricks/client/jdbc/DataSource.java

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,7 @@ public Connection getConnection() throws DatabricksSQLException {
4040

4141
@Override
4242
public Connection getConnection(String username, String password) throws DatabricksSQLException {
43-
LoggingUtil.log(
44-
LogLevel.DEBUG,
45-
String.format(
46-
"public Connection getConnection(String username = {%s}, String password = {%s})",
47-
username, password));
43+
LoggingUtil.log(LogLevel.DEBUG, "public Connection getConnection(String, String)");
4844
if (username != null) {
4945
setUsername(username);
5046
}
@@ -63,11 +59,7 @@ public PooledConnection getPooledConnection() throws DatabricksSQLException {
6359
@Override
6460
public PooledConnection getPooledConnection(String user, String password)
6561
throws DatabricksSQLException {
66-
LoggingUtil.log(
67-
LogLevel.DEBUG,
68-
String.format(
69-
"public PooledConnection getPooledConnection(String user = {%s}, String password = {%s})",
70-
user, password));
62+
LoggingUtil.log(LogLevel.DEBUG, "public PooledConnection getPooledConnection(String, String)");
7163
return new DatabricksPooledConnection(getConnection(user, password));
7264
}
7365

@@ -84,7 +76,7 @@ public void setLogWriter(PrintWriter out) throws SQLException {
8476
@Override
8577
public void setLoginTimeout(int seconds) {
8678
LoggingUtil.log(
87-
LogLevel.INFO, String.format("public void setLoginTimeout(int seconds = {%s})", seconds));
79+
LogLevel.DEBUG, String.format("public void setLoginTimeout(int seconds = {%s})", seconds));
8880
this.properties.put(DatabricksJdbcConstants.LOGIN_TIMEOUT, seconds);
8981
}
9082

@@ -109,7 +101,7 @@ public boolean isWrapperFor(Class<?> iface) throws SQLException {
109101
}
110102

111103
public String getUrl() {
112-
LoggingUtil.log(LogLevel.INFO, "public String getUrl()");
104+
LoggingUtil.log(LogLevel.DEBUG, "public String getUrl()");
113105
StringBuilder urlBuilder = new StringBuilder();
114106
urlBuilder.append(DatabricksJdbcConstants.JDBC_SCHEMA);
115107
if (host == null) {

0 commit comments

Comments
 (0)