[PECO-1685] Fix loglevel and logPath (#198)

Author: samikshya-db

.gitignore

@@ -4,3 +4,4 @@ target/
 *DS_Store
 TestFile
 logs/
+*.log

pom.xml

@@ -19,7 +19,6 @@
     <maven.compiler.source>11</maven.compiler.source>
     <maven.compiler.target>11</maven.compiler.target>
     <mockito.version>5.2.0</mockito.version>
-    <slf4j.version>2.0.7</slf4j.version>
     <jackson.version>2.15.1</jackson.version>
     <google.guava.version>33.0.0-jre</google.guava.version>
     <junit.jupiter.version>5.9.2</junit.jupiter.version>
@@ -32,7 +31,6 @@
     <commons-io.version>2.13.0</commons-io.version>
     <databricks-sdk.version>0.17.0</databricks-sdk.version>
     <maven-surefire-plugin.version>3.1.2</maven-surefire-plugin.version>
-    <slf4j-reload4j.version>2.1.0-alpha1</slf4j-reload4j.version>
     <sql-logic-test.version>0.3</sql-logic-test.version>
     <lz4-compression.version>1.8.0</lz4-compression.version>
     <thrift.version>0.19.0</thrift.version>
@@ -110,11 +108,6 @@
       <version>${mockito.version}</version>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.slf4j</groupId>
-      <artifactId>slf4j-api</artifactId>
-      <version>${slf4j.version}</version>
-    </dependency>
     <dependency>
       <groupId>org.apache.logging.log4j</groupId>
       <artifactId>log4j-api</artifactId>
@@ -141,12 +134,6 @@
       <version>${immutables.value.version}</version>
       <scope>provided</scope>
     </dependency>
-    <dependency>
-      <groupId>org.slf4j</groupId>
-      <artifactId>slf4j-reload4j</artifactId>
-      <version>${slf4j-reload4j.version}</version>
-      <scope>runtime</scope>
-    </dependency>
     <dependency>
       <groupId>net.hydromatic</groupId>
       <artifactId>sql-logic-test</artifactId>
@@ -197,6 +184,9 @@
           <artifactId>maven-surefire-plugin</artifactId>
           <version>${maven-surefire-plugin.version}</version>
           <configuration>
+            <systemPropertyVariables>
+              <log4j.configurationFile>file:src/main/resources/log4j2.xml</log4j.configurationFile>
+            </systemPropertyVariables>
             <excludes>
               <exclude>**/integration/**/*.java</exclude>
               <exclude>**/*MetadataBenchmarkingTest.java</exclude>

src/main/java/com/databricks/jdbc/client/http/DatabricksHttpClient.java

@@ -34,13 +34,13 @@
 import org.apache.http.impl.conn.DefaultSchemePortResolver;
 import org.apache.http.impl.conn.PoolingHttpClientConnectionManager;
 import org.apache.http.protocol.HttpContext;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 /** Http client implementation to be used for executing http requests. */
 public class DatabricksHttpClient implements IDatabricksHttpClient {
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(DatabricksHttpClient.class);
+  private static final Logger LOGGER = LogManager.getLogger(DatabricksHttpClient.class);
 
   // TODO(PECO-1373): Revisit number of connections and connections per route.
   private static final int DEFAULT_MAX_HTTP_CONNECTIONS = 1000;

src/main/java/com/databricks/jdbc/client/impl/helper/CommandBuilder.java

@@ -10,11 +10,11 @@
 import java.sql.SQLException;
 import java.util.Collections;
 import java.util.HashMap;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 public class CommandBuilder {
-  private static final Logger LOGGER = LoggerFactory.getLogger(CommandBuilder.class);
+  private static final Logger LOGGER = LogManager.getLogger(CommandBuilder.class);
   private String catalogName = null;
   private String schemaName = null;
   private String tableName = null;

src/main/java/com/databricks/jdbc/client/impl/sdk/DatabricksMetadataSdkClient.java

@@ -18,13 +18,13 @@
 import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 /** Implementation for DatabricksMetadataClient using SDK client */
 public class DatabricksMetadataSdkClient implements DatabricksMetadataClient {
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(DatabricksSdkClient.class);
+  private static final Logger LOGGER = LogManager.getLogger(DatabricksSdkClient.class);
 
   private final DatabricksSdkClient sdkClient;
 

src/main/java/com/databricks/jdbc/client/impl/sdk/DatabricksNewMetadataSdkClient.java

@@ -12,8 +12,8 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.util.*;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 /**
  * This is for the new SQL commands added in runtime. Note that the DatabricksMetadataSdkClient will
@@ -23,8 +23,7 @@
  */
 public class DatabricksNewMetadataSdkClient implements DatabricksMetadataClient {
 
-  private static final Logger LOGGER =
-      LoggerFactory.getLogger(DatabricksNewMetadataSdkClient.class);
+  private static final Logger LOGGER = LogManager.getLogger(DatabricksNewMetadataSdkClient.class);
   private final DatabricksSdkClient sdkClient;
 
   public DatabricksNewMetadataSdkClient(DatabricksSdkClient sdkClient) {

src/main/java/com/databricks/jdbc/client/impl/sdk/DatabricksSdkClient.java

@@ -29,12 +29,12 @@
 import java.util.List;
 import java.util.Map;
 import java.util.stream.Collectors;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 /** Implementation of DatabricksClient interface using Databricks Java SDK. */
 public class DatabricksSdkClient implements DatabricksClient {
-  private static final Logger LOGGER = LoggerFactory.getLogger(DatabricksSdkClient.class);
+  private static final Logger LOGGER = LogManager.getLogger(DatabricksSdkClient.class);
   private static final String SYNC_TIMEOUT_VALUE = "10s";
   private static final String ASYNC_TIMEOUT_VALUE = "0s";
 

src/main/java/com/databricks/jdbc/client/impl/sdk/DatabricksUCVolumeClient.java

@@ -2,15 +2,15 @@
 
 import com.databricks.jdbc.client.IDatabricksUCVolumeClient;
 import java.sql.*;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 /** Implementation for DatabricksUCVolumeClient */
 public class DatabricksUCVolumeClient implements IDatabricksUCVolumeClient {
 
   private final Connection connection;
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(DatabricksSdkClient.class);
+  private static final Logger LOGGER = LogManager.getLogger(DatabricksSdkClient.class);
 
   public DatabricksUCVolumeClient(Connection connection) {
     this.connection = connection;

src/main/java/com/databricks/jdbc/client/impl/thrift/DatabricksThriftServiceClient.java

@@ -20,12 +20,12 @@
 import java.sql.SQLException;
 import java.util.*;
 import java.util.concurrent.atomic.AtomicInteger;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 public class DatabricksThriftServiceClient implements DatabricksClient, DatabricksMetadataClient {
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(DatabricksThriftServiceClient.class);
+  private static final Logger LOGGER = LogManager.getLogger(DatabricksThriftServiceClient.class);
 
   private final DatabricksThriftAccessor thriftAccessor;
 

src/main/java/com/databricks/jdbc/client/impl/thrift/commons/DatabricksHttpTTransport.java

@@ -13,15 +13,15 @@
 import org.apache.http.HttpResponse;
 import org.apache.http.client.methods.HttpPost;
 import org.apache.http.entity.ByteArrayEntity;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.apache.thrift.TConfiguration;
 import org.apache.thrift.transport.TTransport;
 import org.apache.thrift.transport.TTransportException;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 public class DatabricksHttpTTransport extends TTransport {
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(DatabricksHttpTTransport.class);
+  private static final Logger LOGGER = LogManager.getLogger(DatabricksHttpTTransport.class);
   private final DatabricksHttpClient httpClient;
   private final String url;
   private Map<String, String> customHeaders = Collections.emptyMap();