Fix UC volume GET operation (#602)

* Fix UC volume GET operation

* Add tests

Author: gopalldb

src/main/java/com/databricks/jdbc/api/impl/arrow/ArrowResultChunk.java

@@ -255,7 +255,7 @@ void downloadData(IDatabricksHttpClient httpClient, CompressionCodec compression
       HttpGet getRequest = new HttpGet(uriBuilder.build());
       addHeaders(getRequest, chunkLink.getHttpHeaders());
       // Retry would be done in http client, we should not bother about that here
-      response = httpClient.execute(getRequest);
+      response = httpClient.execute(getRequest, true);
       checkHTTPError(response);
       String context =
           String.format(

src/main/java/com/databricks/jdbc/dbclient/IDatabricksHttpClient.java

@@ -14,4 +14,14 @@ public interface IDatabricksHttpClient {
    * @return http response
    */
   CloseableHttpResponse execute(HttpUriRequest request) throws DatabricksHttpException;
+
+  /**
+   * Executes the given http request and returns the response
+   *
+   * @param request underlying http request
+   * @param supportGzipEncoding whether to support gzip encoding header
+   * @return http response
+   */
+  CloseableHttpResponse execute(HttpUriRequest request, boolean supportGzipEncoding)
+      throws DatabricksHttpException;
 }

src/main/java/com/databricks/jdbc/dbclient/impl/http/DatabricksHttpClient.java

@@ -65,9 +65,15 @@ public class DatabricksHttpClient implements IDatabricksHttpClient, Closeable {
 
   @Override
   public CloseableHttpResponse execute(HttpUriRequest request) throws DatabricksHttpException {
+    return execute(request, false);
+  }
+
+  @Override
+  public CloseableHttpResponse execute(HttpUriRequest request, boolean supportGzipEncoding)
+      throws DatabricksHttpException {
     LOGGER.debug(
         String.format("Executing HTTP request [{%s}]", RequestSanitizer.sanitizeRequest(request)));
-    if (!DriverUtil.isRunningAgainstFake()) {
+    if (!DriverUtil.isRunningAgainstFake() && supportGzipEncoding) {
       // TODO : allow gzip in wiremock
       request.setHeader("Content-Encoding", "gzip");
     }

src/test/java/com/databricks/jdbc/api/impl/arrow/ArrowStreamResultTest.java

@@ -3,6 +3,7 @@
 import static com.databricks.jdbc.TestConstants.*;
 import static java.lang.Math.min;
 import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.ArgumentMatchers.isA;
 import static org.mockito.Mockito.when;
 
@@ -115,7 +116,7 @@ public void testIteration() throws Exception {
     DatabricksSession session = new DatabricksSession(connectionContext, mockedSdkClient);
     setupMockResponse();
     setupResultChunkMocks();
-    when(mockHttpClient.execute(isA(HttpUriRequest.class))).thenReturn(httpResponse);
+    when(mockHttpClient.execute(isA(HttpUriRequest.class), eq(true))).thenReturn(httpResponse);
 
     ArrowStreamResult result =
         new ArrowStreamResult(resultManifest, resultData, STATEMENT_ID, session, mockHttpClient);
@@ -195,7 +196,7 @@ public void testGetObject() throws Exception {
     DatabricksSession session = new DatabricksSession(connectionContext, mockedSdkClient);
 
     setupMockResponse();
-    when(mockHttpClient.execute(isA(HttpUriRequest.class))).thenReturn(httpResponse);
+    when(mockHttpClient.execute(isA(HttpUriRequest.class), eq(true))).thenReturn(httpResponse);
 
     ArrowStreamResult result =
         new ArrowStreamResult(resultManifest, resultData, STATEMENT_ID, session, mockHttpClient);

src/test/java/com/databricks/jdbc/dbclient/impl/http/DatabricksHttpClientTest.java

@@ -171,6 +171,22 @@ public void testSetFakeServiceRouteInHttpClientThrowsHTTPError() {
     System.clearProperty(testTargetURI + FAKE_SERVICE_URI_PROP_SUFFIX);
   }
 
+  @Test
+  void testExecuteWithGzipHeaders() throws Exception {
+    HttpUriRequest request = new HttpGet("https://databricks.com");
+    databricksHttpClient.execute(request);
+
+    assertFalse(request.containsHeader("Content-Encoding"));
+
+    System.setProperty(IS_FAKE_SERVICE_TEST_PROP, "true");
+    databricksHttpClient.execute(request, true);
+    assertFalse(request.containsHeader("Content-Encoding"));
+    System.setProperty(IS_FAKE_SERVICE_TEST_PROP, "false");
+
+    databricksHttpClient.execute(request, true);
+    assertTrue(request.containsHeader("Content-Encoding"));
+  }
+
   @Test
   void testExecuteThrowsError() throws IOException {
     when(mockRequest.getURI()).thenReturn(URI.create("https://databricks.com"));