[PECOBLR-322] Update SDK to the latest version (0.43.0) (#781)

Author: vikrantpuppala

.gitignore

@@ -1,4 +1,5 @@
 .idea/
+.vscode/
 target/
 *.iml
 *DS_Store

pom.xml

@@ -52,8 +52,9 @@
     <google.findbugs.annotations.version>3.0.1</google.findbugs.annotations.version>
     <immutables.value.version>2.9.2</immutables.value.version>
     <httpclient.version>4.5.14</httpclient.version>
+    <commons-configuration.version>2.10.1</commons-configuration.version>
     <commons-io.version>2.14.0</commons-io.version>
-    <databricks-sdk.version>0.37.0</databricks-sdk.version>
+    <databricks-sdk.version>0.43.0</databricks-sdk.version>
     <maven-surefire-plugin.version>3.1.2</maven-surefire-plugin.version>
     <sql-logic-test.version>0.3</sql-logic-test.version>
     <lz4-compression.version>1.8.0</lz4-compression.version>
@@ -72,6 +73,11 @@
       <artifactId>databricks-sdk-java</artifactId>
       <version>${databricks-sdk.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.commons</groupId>
+      <artifactId>commons-configuration2</artifactId>
+      <version>${commons-configuration.version}</version>
+    </dependency>
     <dependency>
       <groupId>org.apache.arrow</groupId>
       <artifactId>arrow-memory-core</artifactId>

src/main/java/com/databricks/jdbc/api/impl/DatabricksConnectionContext.java

@@ -687,12 +687,10 @@ public List<Integer> getOAuth2RedirectUrlPorts() {
           .map(Integer::parseInt)
           .collect(Collectors.toList());
     } catch (NumberFormatException e) {
-      LOGGER.warn(
-          "Invalid port format in OAuth2RedirectUrlPort: {}. Using default port {}.",
-          portsStr,
-          DatabricksJdbcUrlParams.OAUTH_REDIRECT_URL_PORT.getDefaultValue());
-      return List.of(
-          Integer.parseInt(DatabricksJdbcUrlParams.OAUTH_REDIRECT_URL_PORT.getDefaultValue()));
+      String errorMessage =
+          String.format("Invalid port format in OAuth2RedirectUrlPort: %s.", portsStr);
+      LOGGER.error(errorMessage, e);
+      throw new IllegalArgumentException(errorMessage);
     }
   }
 

src/main/java/com/databricks/jdbc/api/impl/volume/DBFSVolumeClient.java

@@ -23,8 +23,10 @@
 import com.databricks.jdbc.model.client.filesystem.*;
 import com.databricks.jdbc.model.telemetry.enums.DatabricksDriverErrorCode;
 import com.databricks.sdk.WorkspaceClient;
+import com.databricks.sdk.core.ApiClient;
 import com.databricks.sdk.core.DatabricksException;
 import com.databricks.sdk.core.error.platform.NotFound;
+import com.databricks.sdk.core.http.Request;
 import com.google.common.annotations.VisibleForTesting;
 import java.io.Closeable;
 import java.io.IOException;
@@ -44,19 +46,22 @@ public class DBFSVolumeClient implements IDatabricksVolumeClient, Closeable {
   private VolumeInputStream volumeInputStream = null;
   private long volumeStreamContentLength = -1L;
   final WorkspaceClient workspaceClient;
+  final ApiClient apiClient;
   private final String allowedVolumeIngestionPaths;
 
   @VisibleForTesting
   public DBFSVolumeClient(WorkspaceClient workspaceClient) {
     this.connectionContext = null;
     this.workspaceClient = workspaceClient;
+    this.apiClient = workspaceClient.apiClient();
     this.databricksHttpClient = null;
     this.allowedVolumeIngestionPaths = "";
   }
 
   public DBFSVolumeClient(IDatabricksConnectionContext connectionContext) {
     this.connectionContext = connectionContext;
     this.workspaceClient = getWorkspaceClientFromConnectionContext(connectionContext);
+    this.apiClient = workspaceClient.apiClient();
     this.databricksHttpClient =
         DatabricksHttpClientFactory.getInstance()
             .getClient(connectionContext, HttpClientType.VOLUME);
@@ -403,10 +408,10 @@ CreateUploadUrlResponse getCreateUploadUrlResponse(String objectPath)
 
     CreateUploadUrlRequest request = new CreateUploadUrlRequest(objectPath);
     try {
-      return workspaceClient
-          .apiClient()
-          .POST(CREATE_UPLOAD_URL_PATH, request, CreateUploadUrlResponse.class, JSON_HTTP_HEADERS);
-    } catch (DatabricksException e) {
+      Request req = new Request(Request.POST, CREATE_UPLOAD_URL_PATH, apiClient.serialize(request));
+      req.withHeaders(JSON_HTTP_HEADERS);
+      return apiClient.execute(req, CreateUploadUrlResponse.class);
+    } catch (IOException | DatabricksException e) {
       String errorMessage =
           String.format("Failed to get create upload url response - {%s}", e.getMessage());
       LOGGER.error(e, errorMessage);
@@ -426,14 +431,11 @@ CreateDownloadUrlResponse getCreateDownloadUrlResponse(String objectPath)
     CreateDownloadUrlRequest request = new CreateDownloadUrlRequest(objectPath);
 
     try {
-      return workspaceClient
-          .apiClient()
-          .POST(
-              CREATE_DOWNLOAD_URL_PATH,
-              request,
-              CreateDownloadUrlResponse.class,
-              JSON_HTTP_HEADERS);
-    } catch (DatabricksException e) {
+      Request req =
+          new Request(Request.POST, CREATE_DOWNLOAD_URL_PATH, apiClient.serialize(request));
+      req.withHeaders(JSON_HTTP_HEADERS);
+      return apiClient.execute(req, CreateDownloadUrlResponse.class);
+    } catch (IOException | DatabricksException e) {
       String errorMessage =
           String.format("Failed to get create download url response - {%s}", e.getMessage());
       LOGGER.error(e, errorMessage);
@@ -452,10 +454,10 @@ CreateDeleteUrlResponse getCreateDeleteUrlResponse(String objectPath)
     CreateDeleteUrlRequest request = new CreateDeleteUrlRequest(objectPath);
 
     try {
-      return workspaceClient
-          .apiClient()
-          .POST(CREATE_DELETE_URL_PATH, request, CreateDeleteUrlResponse.class, JSON_HTTP_HEADERS);
-    } catch (DatabricksException e) {
+      Request req = new Request(Request.POST, CREATE_DELETE_URL_PATH, apiClient.serialize(request));
+      req.withHeaders(JSON_HTTP_HEADERS);
+      return apiClient.execute(req, CreateDeleteUrlResponse.class);
+    } catch (IOException | DatabricksException e) {
       String errorMessage =
           String.format("Failed to get create delete url response - {%s}", e.getMessage());
       LOGGER.error(e, errorMessage);
@@ -470,10 +472,11 @@ ListResponse getListResponse(String listPath) throws DatabricksVolumeOperationEx
         String.format("Entering getListResponse method with parameters : listPath={%s}", listPath));
     ListRequest request = new ListRequest(listPath);
     try {
-      return workspaceClient
-          .apiClient()
-          .GET(LIST_PATH, request, ListResponse.class, JSON_HTTP_HEADERS);
-    } catch (DatabricksException e) {
+      Request req = new Request(Request.GET, LIST_PATH);
+      req.withHeaders(JSON_HTTP_HEADERS);
+      ApiClient.setQuery(req, request);
+      return apiClient.execute(req, ListResponse.class);
+    } catch (IOException | DatabricksException e) {
       String errorMessage = String.format("Failed to get list response - {%s}", e.getMessage());
       LOGGER.error(e, errorMessage);
       throw new DatabricksVolumeOperationException(

src/main/java/com/databricks/jdbc/dbclient/impl/common/ClientConfigurator.java

@@ -143,7 +143,7 @@ public void setupU2MConfig() throws DatabricksParsingException {
         .setClientSecret(connectionContext.getClientSecret())
         .setOAuthRedirectUrl(redirectUrl);
 
-    LOGGER.info("Using OAuth redirect URL: {}", redirectUrl);
+    LOGGER.info("Using OAuth redirect URL: %s", redirectUrl);
 
     if (!databricksConfig.isAzure()) {
       databricksConfig.setScopes(connectionContext.getOAuthScopesForU2M());
@@ -171,25 +171,23 @@ int findAvailablePort(List<Integer> initialPorts) {
         portsToTry.add(startPort + i);
       }
       LOGGER.debug(
-          "Single port provided ({}), will try ports {} through {}",
-          startPort,
-          startPort,
-          startPort + maxAttempts - 1);
+          "Single port provided (%s), will try ports %s through %s",
+          startPort, startPort, startPort + maxAttempts - 1);
     } else {
       portsToTry = initialPorts;
-      LOGGER.debug("Multiple ports provided, will try: {}", portsToTry);
+      LOGGER.debug("Multiple ports provided, will try: %s", portsToTry);
     }
 
     // Try each port in the list
     for (int port : portsToTry) {
       if (isPortAvailable(port)) {
         return port;
       }
-      LOGGER.debug("Port {} is not available, trying next port", port);
+      LOGGER.debug("Port %s is not available, trying next port", port);
     }
 
     // No available ports found
-    LOGGER.error("No available ports found among: {}", portsToTry);
+    LOGGER.error("No available ports found among: %s", portsToTry);
     throw new DatabricksException(
         "No available port found for OAuth redirect URL. Tried ports: " + portsToTry);
   }