Skip to content

Commit 7765156

Browse files
[PECO-1890] Add builder to ArrowResultChunk and other clean-up (#414)
These changes are part of team's OSS effort - Add builder to improve readability and flexibility - Simplify the usage of arrow classes to read arrow data - Catch specific exceptions - Cosmetic changes
1 parent 57e1346 commit 7765156

File tree

11 files changed

+251
-210
lines changed

11 files changed

+251
-210
lines changed

src/main/java/com/databricks/jdbc/api/impl/DatabricksResultSet.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import com.databricks.jdbc.common.StatementType;
1313
import com.databricks.jdbc.common.util.LoggingUtil;
1414
import com.databricks.jdbc.common.util.WarningUtil;
15+
import com.databricks.jdbc.exception.DatabricksParsingException;
1516
import com.databricks.jdbc.exception.DatabricksSQLException;
1617
import com.databricks.jdbc.exception.DatabricksSQLFeatureNotSupportedException;
1718
import com.databricks.jdbc.model.client.thrift.generated.TGetResultSetMetadataResp;
@@ -56,7 +57,8 @@ public DatabricksResultSet(
5657
ResultManifest resultManifest,
5758
StatementType statementType,
5859
IDatabricksSession session,
59-
IDatabricksStatement parentStatement) {
60+
IDatabricksStatement parentStatement)
61+
throws DatabricksParsingException {
6062
this.statementStatus = statementStatus;
6163
this.statementId = statementId;
6264
this.executionResult =

src/main/java/com/databricks/jdbc/api/impl/ExecutionResultFactory.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import com.databricks.jdbc.api.impl.inline.InlineJsonResult;
1010
import com.databricks.jdbc.api.impl.volume.VolumeOperationResult;
1111
import com.databricks.jdbc.common.util.DatabricksThriftUtil;
12+
import com.databricks.jdbc.exception.DatabricksParsingException;
1213
import com.databricks.jdbc.exception.DatabricksSQLException;
1314
import com.databricks.jdbc.exception.DatabricksSQLFeatureNotImplementedException;
1415
import com.databricks.jdbc.exception.DatabricksSQLFeatureNotSupportedException;
@@ -25,7 +26,8 @@ static IExecutionResult getResultSet(
2526
String statementId,
2627
IDatabricksSession session,
2728
IDatabricksStatement statement,
28-
IDatabricksResultSet resultSet) {
29+
IDatabricksResultSet resultSet)
30+
throws DatabricksParsingException {
2931
IExecutionResult resultHandler = getResultHandler(data, manifest, statementId, session);
3032
if (manifest.getIsVolumeOperation() != null && manifest.getIsVolumeOperation()) {
3133
return new VolumeOperationResult(
@@ -42,7 +44,8 @@ static IExecutionResult getResultSet(
4244
}
4345

4446
private static IExecutionResult getResultHandler(
45-
ResultData data, ResultManifest manifest, String statementId, IDatabricksSession session) {
47+
ResultData data, ResultManifest manifest, String statementId, IDatabricksSession session)
48+
throws DatabricksParsingException {
4649
if (manifest.getFormat() == null) {
4750
throw new IllegalStateException("Empty response format");
4851
}

0 commit comments

Comments
 (0)