Remove dead telemetry code (#540)

* Remove telemetry

* Remove todos

Author: samikshya-db

src/main/java/com/databricks/client/jdbc/Driver.java

@@ -54,8 +54,6 @@ public Connection connect(String url, Properties info) throws DatabricksSQLExcep
     try {
       connection.open();
       isConnectionOpen = true;
-      // TODO (PECO-1957): Export properties asynchronously
-      // DeviceInfoLogUtil.exportDeviceProperties(connection.getSession());
       resolveMetadataClient(connection, connectionContext);
       return connection;
     } catch (Exception e) {
@@ -74,8 +72,6 @@ public Connection connect(String url, Properties info) throws DatabricksSQLExcep
         errorMessage += e.getMessage();
       }
 
-      MetricsUtil.exportErrorWithoutAuth(
-          ErrorTypes.COMMUNICATION_FAILURE, null, ErrorCodes.COMMUNICATION_FAILURE);
       throw new DatabricksSQLException(
           errorMessage,
           rootCause,

src/main/java/com/databricks/jdbc/api/IDatabricksConnectionContext.java

@@ -157,8 +157,6 @@ public static AuthMech parseAuthMech(String authMech) {
 
   boolean supportManyParameters();
 
-  boolean enableTelemetry();
-
   String getConnectionURL();
 
   boolean checkCertificateRevocation();

src/main/java/com/databricks/jdbc/api/IDatabricksSession.java

@@ -6,7 +6,6 @@
 import com.databricks.jdbc.dbclient.IDatabricksClient;
 import com.databricks.jdbc.dbclient.IDatabricksMetadataClient;
 import com.databricks.jdbc.exception.DatabricksSQLException;
-import com.databricks.jdbc.telemetry.DatabricksMetrics;
 import java.util.Map;
 import javax.annotation.Nullable;
 
@@ -84,7 +83,4 @@ public interface IDatabricksSession {
   IDatabricksConnectionContext getConnectionContext();
 
   void setEmptyMetadataClient();
-
-  /** Returns the metrics exporter for the session */
-  DatabricksMetrics getMetricsExporter();
 }

src/main/java/com/databricks/jdbc/api/impl/DatabricksConnectionContext.java

@@ -479,11 +479,6 @@ public boolean supportManyParameters() {
     return getParameter(DatabricksJdbcUrlParams.SUPPORT_MANY_PARAMETERS).equals("1");
   }
 
-  @Override
-  public boolean enableTelemetry() {
-    return Objects.equals(getParameter(DatabricksJdbcUrlParams.ENABLE_TELEMETRY), "1");
-  }
-
   @Override
   public String getConnectionURL() {
     return connectionURL;

src/main/java/com/databricks/jdbc/api/impl/DatabricksSession.java

@@ -15,8 +15,6 @@
 import com.databricks.jdbc.exception.DatabricksSQLException;
 import com.databricks.jdbc.log.JdbcLogger;
 import com.databricks.jdbc.log.JdbcLoggerFactory;
-import com.databricks.jdbc.telemetry.DatabricksMetrics;
-import com.databricks.jdbc.telemetry.annotation.DatabricksMetricsTimedProcessor;
 import com.databricks.sdk.support.ToStringer;
 import com.google.common.annotations.VisibleForTesting;
 import java.util.HashMap;
@@ -44,7 +42,6 @@ public class DatabricksSession implements IDatabricksSession {
   private final Map<String, String> clientInfoProperties;
   private final CompressionType compressionType;
   private final IDatabricksConnectionContext connectionContext;
-  private final DatabricksMetrics metricsExporter;
 
   /**
    * Creates an instance of Databricks session for given connection context
@@ -68,9 +65,6 @@ public DatabricksSession(IDatabricksConnectionContext connectionContext)
     this.clientInfoProperties = new HashMap<>();
     this.compressionType = connectionContext.getCompressionType();
     this.connectionContext = connectionContext;
-    this.metricsExporter = new DatabricksMetrics(connectionContext);
-    this.databricksClient =
-        DatabricksMetricsTimedProcessor.createProxy(this.databricksClient, metricsExporter);
   }
 
   /** Constructor method to be used for mocking in a test case. */
@@ -89,7 +83,6 @@ public DatabricksSession(
     this.sessionConfigs = connectionContext.getSessionConfigs();
     this.clientInfoProperties = new HashMap<>();
     this.compressionType = connectionContext.getCompressionType();
-    this.metricsExporter = new DatabricksMetrics(connectionContext);
     this.connectionContext = connectionContext;
   }
 
@@ -147,7 +140,6 @@ public void close() throws DatabricksSQLException {
         databricksClient.deleteSession(this, computeResource);
         this.sessionInfo = null;
         this.isSessionOpen = false;
-        this.getMetricsExporter().close();
       }
     }
   }
@@ -244,8 +236,4 @@ public IDatabricksConnectionContext getConnectionContext() {
   public void setEmptyMetadataClient() {
     databricksMetadataClient = new DatabricksEmptyMetadataClient();
   }
-
-  public DatabricksMetrics getMetricsExporter() {
-    return this.metricsExporter;
-  }
 }

src/main/java/com/databricks/jdbc/api/impl/DatabricksStatement.java

@@ -9,7 +9,6 @@
 import com.databricks.jdbc.api.IDatabricksStatement;
 import com.databricks.jdbc.api.callback.IDatabricksStatementHandle;
 import com.databricks.jdbc.common.ErrorCodes;
-import com.databricks.jdbc.common.ErrorTypes;
 import com.databricks.jdbc.common.StatementType;
 import com.databricks.jdbc.common.util.*;
 import com.databricks.jdbc.dbclient.IDatabricksClient;
@@ -61,11 +60,6 @@ public ResultSet executeQuery(String sql) throws SQLException {
               + sql
               + ". However, query "
               + "execution was successful.";
-      MetricsUtil.exportError(
-          connection.getSession(),
-          ErrorTypes.EXECUTE_STATEMENT,
-          statementId,
-          ErrorCodes.RESULT_SET_ERROR);
       throw new DatabricksSQLException(errorMessage, ErrorCodes.RESULT_SET_ERROR);
     }
     return rs;
@@ -107,23 +101,13 @@ public void close(boolean removeFromSession) throws DatabricksSQLException {
   @Override
   public int getMaxFieldSize() throws SQLException {
     LOGGER.debug("public int getMaxFieldSize()");
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.MAX_FIELD_SIZE_EXCEEDED);
     throw new DatabricksSQLFeatureNotSupportedException(
         "Not implemented in DatabricksStatement - getMaxFieldSize()");
   }
 
   @Override
   public void setMaxFieldSize(int max) throws SQLException {
     LOGGER.debug(String.format("public void setMaxFieldSize(int max = {%s})", max));
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.MAX_FIELD_SIZE_EXCEEDED);
     throw new DatabricksSQLFeatureNotSupportedException(
         "Not implemented in DatabricksStatement - setMaxFieldSize(int max)");
   }
@@ -192,11 +176,6 @@ public void clearWarnings() {
   @Override
   public void setCursorName(String name) throws SQLException {
     LOGGER.debug(String.format("public void setCursorName(String name = {%s})", name));
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.CURSOR_NAME_NOT_FOUND);
     throw new DatabricksSQLFeatureNotSupportedException(
         "Not implemented in DatabricksStatement - setCursorName(String name)");
   }
@@ -226,11 +205,6 @@ public int getUpdateCount() throws SQLException {
   @Override
   public boolean getMoreResults() throws SQLException {
     LOGGER.debug("public boolean getMoreResults()");
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.MORE_RESULTS_UNSUPPORTED);
     throw new DatabricksSQLFeatureNotSupportedException(
         "Not implemented in DatabricksStatement - getMoreResults()");
   }
@@ -240,11 +214,6 @@ public void setFetchDirection(int direction) throws SQLException {
     LOGGER.debug(String.format("public void setFetchDirection(int direction = {%s})", direction));
     checkIfClosed();
     if (direction != ResultSet.FETCH_FORWARD) {
-      MetricsUtil.exportError(
-          connection.getSession(),
-          ErrorTypes.FEATURE_NOT_SUPPORTED,
-          statementId,
-          ErrorCodes.UNSUPPORTED_FETCH_FORWARD);
       throw new DatabricksSQLFeatureNotSupportedException("Not supported: ResultSet.FetchForward");
     }
   }
@@ -297,11 +266,6 @@ public int getResultSetType() throws SQLException {
   public void addBatch(String sql) throws SQLException {
     LOGGER.debug(String.format("public void addBatch(String sql = {%s})", sql));
     checkIfClosed();
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.BATCH_OPERATION_UNSUPPORTED);
     throw new DatabricksSQLFeatureNotSupportedException(
         "Method not supported: addBatch(String sql)");
   }
@@ -310,23 +274,13 @@ public void addBatch(String sql) throws SQLException {
   public void clearBatch() throws SQLException {
     LOGGER.debug("public void clearBatch()");
     checkIfClosed();
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.BATCH_OPERATION_UNSUPPORTED);
     throw new DatabricksSQLFeatureNotSupportedException("Method not supported: clearBatch()");
   }
 
   @Override
   public int[] executeBatch() throws SQLException {
     LOGGER.debug("public int[] executeBatch()");
     checkIfClosed();
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.BATCH_OPERATION_UNSUPPORTED);
     throw new DatabricksSQLFeatureNotSupportedException("Method not supported: executeBatch()");
   }
 
@@ -339,11 +293,6 @@ public Connection getConnection() throws SQLException {
   @Override
   public boolean getMoreResults(int current) throws SQLException {
     LOGGER.debug(String.format("public boolean getMoreResults(int current = {%s})", current));
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.MORE_RESULTS_UNSUPPORTED);
     throw new DatabricksSQLFeatureNotSupportedException(
         "Not implemented in DatabricksStatement - getMoreResults(int current)");
   }
@@ -361,11 +310,6 @@ public int executeUpdate(String sql, int autoGeneratedKeys) throws SQLException
     if (autoGeneratedKeys == Statement.NO_GENERATED_KEYS) {
       return executeUpdate(sql);
     } else {
-      MetricsUtil.exportError(
-          connection.getSession(),
-          ErrorTypes.FEATURE_NOT_SUPPORTED,
-          statementId,
-          ErrorCodes.EXECUTE_METHOD_UNSUPPORTED);
       throw new DatabricksSQLFeatureNotSupportedException(
           "Method not supported: executeUpdate(String sql, int autoGeneratedKeys)");
     }
@@ -374,11 +318,6 @@ public int executeUpdate(String sql, int autoGeneratedKeys) throws SQLException
   @Override
   public int executeUpdate(String sql, int[] columnIndexes) throws SQLException {
     checkIfClosed();
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.EXECUTE_METHOD_UNSUPPORTED);
     throw new DatabricksSQLFeatureNotSupportedException(
         "Method not supported: executeUpdate(String sql, int[] columnIndexes)");
   }
@@ -387,11 +326,6 @@ public int executeUpdate(String sql, int[] columnIndexes) throws SQLException {
   public int executeUpdate(String sql, String[] columnNames) throws SQLException {
     LOGGER.debug("public int executeUpdate(String sql, String[] columnNames)");
     checkIfClosed();
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.EXECUTE_METHOD_UNSUPPORTED);
     throw new DatabricksSQLFeatureNotSupportedException(
         "Method not supported: executeUpdate(String sql, String[] columnNames)");
   }
@@ -402,11 +336,6 @@ public boolean execute(String sql, int autoGeneratedKeys) throws SQLException {
     if (autoGeneratedKeys == Statement.NO_GENERATED_KEYS) {
       return execute(sql);
     } else {
-      MetricsUtil.exportError(
-          connection.getSession(),
-          ErrorTypes.FEATURE_NOT_SUPPORTED,
-          statementId,
-          ErrorCodes.EXECUTE_METHOD_UNSUPPORTED);
       throw new DatabricksSQLFeatureNotSupportedException(
           "Method not supported: execute(String sql, int autoGeneratedKeys)");
     }
@@ -415,23 +344,13 @@ public boolean execute(String sql, int autoGeneratedKeys) throws SQLException {
   @Override
   public boolean execute(String sql, int[] columnIndexes) throws SQLException {
     checkIfClosed();
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.EXECUTE_METHOD_UNSUPPORTED);
     throw new DatabricksSQLFeatureNotSupportedException(
         "Method not supported: execute(String sql, int[] columnIndexes)");
   }
 
   @Override
   public boolean execute(String sql, String[] columnNames) throws SQLException {
     checkIfClosed();
-    MetricsUtil.exportError(
-        connection.getSession(),
-        ErrorTypes.FEATURE_NOT_SUPPORTED,
-        statementId,
-        ErrorCodes.EXECUTE_METHOD_UNSUPPORTED);
     throw new DatabricksSQLFeatureNotSupportedException(
         "Method not supported: execute(String sql, String[] columnNames)");
   }
@@ -453,11 +372,6 @@ public void setPoolable(boolean poolable) throws SQLException {
     LOGGER.debug(String.format("public void setPoolable(boolean poolable = {%s})", poolable));
     checkIfClosed();
     if (poolable) {
-      MetricsUtil.exportError(
-          connection.getSession(),
-          ErrorTypes.FEATURE_NOT_SUPPORTED,
-          statementId,
-          ErrorCodes.POOLABLE_METHOD_UNSUPPORTED);
       throw new DatabricksSQLFeatureNotSupportedException(
           "Method not supported: setPoolable(boolean poolable)");
     }
@@ -538,11 +452,6 @@ DatabricksResultSet executeInternal(
               stackTraceMessage, statementId);
       LOGGER.error(timeoutErrorMessage);
       futureResultSet.cancel(true); // Cancel execution run
-      MetricsUtil.exportError(
-          this.connection.getSession(),
-          ErrorTypes.TIMEOUT_ERROR,
-          statementId,
-          ErrorCodes.STATEMENT_EXECUTION_TIMEOUT);
       throw new DatabricksTimeoutException(timeoutErrorMessage, e);
     } catch (InterruptedException | ExecutionException e) {
       Throwable cause = e;
@@ -557,11 +466,6 @@ DatabricksResultSet executeInternal(
           String.format(
               "Error occurred during statement execution: %s. Error : %s", sql, e.getMessage());
       LOGGER.error(e, errMsg);
-      MetricsUtil.exportError(
-          this.connection.getSession(),
-          ErrorTypes.EXECUTE_STATEMENT,
-          "",
-          ErrorCodes.EXECUTE_STATEMENT_FAILED);
       throw new DatabricksSQLException(errMsg, e, "", ErrorCodes.EXECUTE_STATEMENT_FAILED);
     }
     LOGGER.debug("Result retrieved successfully" + resultSet.toString());

src/main/java/com/databricks/jdbc/api/impl/arrow/ArrowResultChunk.java

@@ -398,11 +398,11 @@ private void logAllocatorStats(String event) {
     long headRoom = rootAllocator.getHeadroom();
     long initReservation = rootAllocator.getInitReservation();
 
-    String telemetryLog =
+    String allocatorStatsLog =
         String.format(
-            "Chunk telemetry - Event: %s, Chunk Index: %s, Allocated Memory: %s, Peak Memory: %s, Headroom: %s, Init Reservation: %s",
+            "Chunk allocator stats Log - Event: %s, Chunk Index: %s, Allocated Memory: %s, Peak Memory: %s, Headroom: %s, Init Reservation: %s",
             event, chunkIndex, allocatedMemory, peakMemory, headRoom, initReservation);
-    LOGGER.debug(telemetryLog);
+    LOGGER.debug(allocatorStatsLog);
   }
 
   public static class Builder {

src/main/java/com/databricks/jdbc/api/impl/arrow/ChunkDownloader.java

@@ -2,9 +2,6 @@
 
 import com.databricks.jdbc.api.IDatabricksSession;
 import com.databricks.jdbc.common.CompressionType;
-import com.databricks.jdbc.common.ErrorCodes;
-import com.databricks.jdbc.common.ErrorTypes;
-import com.databricks.jdbc.common.util.MetricsUtil;
 import com.databricks.jdbc.dbclient.IDatabricksHttpClient;
 import com.databricks.jdbc.dbclient.impl.http.DatabricksHttpClient;
 import com.databricks.jdbc.exception.DatabricksParsingException;
@@ -137,8 +134,6 @@ ArrowResultChunk getChunk() throws DatabricksSQLException {
           chunk.wait();
         }
         if (chunk.getStatus() != ArrowResultChunk.ChunkStatus.DOWNLOAD_SUCCEEDED) {
-          MetricsUtil.exportError(
-              session, ErrorTypes.CHUNK_DOWNLOAD, statementId, ErrorCodes.CHUNK_DOWNLOAD_ERROR);
           throw new DatabricksSQLException(chunk.getErrorMessage());
         }
       } catch (InterruptedException e) {
@@ -238,11 +233,11 @@ private static ConcurrentHashMap<Long, ArrowResultChunk> initializeChunksMap(
       return chunkIndexMap;
     }
     for (TSparkArrowResultLink resultLink : resultData.getResultLinks()) {
-      String telemetryLog =
+      String chunkInformationLog =
           String.format(
-              "Manifest telemetry - Row Offset: %s, Row Count: %s, Expiry Time: %s",
+              "Chunk information log - Row Offset: %s, Row Count: %s, Expiry Time: %s",
               resultLink.getStartRowOffset(), resultLink.getRowCount(), resultLink.getExpiryTime());
-      LOGGER.debug(telemetryLog);
+      LOGGER.debug(chunkInformationLog);
       chunkIndexMap.put(
           chunkIndex,
           ArrowResultChunk.builder()