fix handling of null for thrift

madhav-db · madhav-db · commit cbbc1b114cf7 · 2024-07-31T20:36:49.000+05:30
diff --git a/src/main/java/com/databricks/jdbc/client/impl/thrift/commons/DatabricksThriftHelper.java b/src/main/java/com/databricks/jdbc/client/impl/thrift/commons/DatabricksThriftHelper.java
@@ -194,7 +194,8 @@ private static List<?> getColumnValues(TColumn column) {
     if (column.isSetStringVal())
       return getColumnValuesWithNulls(
           column.getStringVal().getValues(), column.getStringVal().getNulls());
-    return null; // Return null if no valid value set
+    return getColumnValuesWithNulls(
+        column.getStringVal().getValues(), column.getStringVal().getNulls()); // default to string
   }
 
   private static <T> List<T> getColumnValuesWithNulls(List<T> values, byte[] nulls) {

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,8 @@ private static List<?> getColumnValues(TColumn column) {`
`194`	`194`	`if (column.isSetStringVal())`
`195`	`195`	`return getColumnValuesWithNulls(`
`196`	`196`	`column.getStringVal().getValues(), column.getStringVal().getNulls());`
`197`		`- return null; // Return null if no valid value set`
	`197`	`+ return getColumnValuesWithNulls(`
	`198`	`+ column.getStringVal().getValues(), column.getStringVal().getNulls()); // default to string`
`198`	`199`	`}`
`199`	`200`
`200`	`201`	`private static <T> List<T> getColumnValuesWithNulls(List<T> values, byte[] nulls) {`