Skip to content

Commit f03ae9b

Browse files
Resolved comments - CamelCase + function name
1 parent 9ae82b1 commit f03ae9b

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/main/java/com/databricks/jdbc/client/impl/sdk/DatabricksSdkClient.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class DatabricksSdkClient implements DatabricksClient {
3737
private static final Logger LOGGER = LoggerFactory.getLogger(DatabricksSdkClient.class);
3838
private static final String SYNC_TIMEOUT_VALUE = "10s";
3939
private static final String ASYNC_TIMEOUT_VALUE = "0s";
40-
private int STATEMENT_RESULT_POLL_INTERVAL_MILLIS = 200;
40+
private int statementResultPollIntervalMillis = 200;
4141

4242
private final IDatabricksConnectionContext connectionContext;
4343
private final DatabricksConfig databricksConfig;
@@ -61,7 +61,7 @@ public DatabricksSdkClient(IDatabricksConnectionContext connectionContext)
6161

6262
OAuthAuthenticator authenticator = new OAuthAuthenticator(connectionContext);
6363
this.workspaceClient = authenticator.getWorkspaceClient();
64-
this.STATEMENT_RESULT_POLL_INTERVAL_MILLIS = connectionContext.getInterval();
64+
this.statementResultPollIntervalMillis = connectionContext.getAsyncExecPollInterval();
6565
}
6666

6767
public DatabricksSdkClient(
@@ -79,7 +79,7 @@ public DatabricksSdkClient(
7979
new WorkspaceClient(true /* mock */, apiClient)
8080
.withStatementExecutionImpl(statementExecutionService);
8181

82-
this.STATEMENT_RESULT_POLL_INTERVAL_MILLIS = connectionContext.getInterval();
82+
this.statementResultPollIntervalMillis = connectionContext.getAsyncExecPollInterval();
8383
}
8484

8585
@Override
@@ -163,7 +163,7 @@ public DatabricksResultSet executeStatement(
163163
while (responseState == StatementState.PENDING || responseState == StatementState.RUNNING) {
164164
if (pollCount > 0) { // First poll happens without a delay
165165
try {
166-
Thread.sleep(STATEMENT_RESULT_POLL_INTERVAL_MILLIS);
166+
Thread.sleep(statementResultPollIntervalMillis);
167167
} catch (InterruptedException e) {
168168
throw new DatabricksTimeoutException("Thread interrupted due to statement timeout");
169169
}

src/main/java/com/databricks/jdbc/driver/DatabricksConnectionContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ public String getToken() {
173173
}
174174

175175
@Override
176-
public int getInterval() {
176+
public int getAsyncExecPollInterval() {
177177
return getParameter(POLL_INTERVAL) == null
178178
? POLL_INTERVAL_DEFAULT
179179
: Integer.parseInt((getParameter(DatabricksJdbcConstants.POLL_INTERVAL)));

src/main/java/com/databricks/jdbc/driver/IDatabricksConnectionContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public static AuthMech parseAuthMech(String authMech) {
114114

115115
String getEndpointURL() throws DatabricksParsingException;
116116

117-
int getInterval();
117+
int getAsyncExecPollInterval();
118118

119119
DatabricksClientType getClientType();
120120
}

src/test/java/com/databricks/jdbc/driver/DatabricksConnectionContextTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,12 +253,12 @@ public void testParsingOfUrlWithoutDefault() throws DatabricksSQLException {
253253
public void testPollingInterval() throws DatabricksSQLException {
254254
DatabricksConnectionContext connectionContext =
255255
(DatabricksConnectionContext) DatabricksConnectionContext.parse(VALID_URL_5, properties);
256-
assertEquals(200, connectionContext.getInterval());
256+
assertEquals(200, connectionContext.getAsyncExecPollInterval());
257257

258258
DatabricksConnectionContext connectionContextWithPoll =
259259
(DatabricksConnectionContext)
260260
DatabricksConnectionContext.parse(VALID_URL_POLLING, properties);
261-
assertEquals(500, connectionContextWithPoll.getInterval());
261+
assertEquals(500, connectionContextWithPoll.getAsyncExecPollInterval());
262262
}
263263

264264
@Test

0 commit comments

Comments
 (0)